New issue
Advanced search Search tips

Issue 625063 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 578029



Sign in to add a comment

MissCachedInterventionResult metric should not be counted for resources provided in data url form.

Project Member Reported by toyoshim@chromium.org, Jul 1 2016

Issue description

MissCachedInterventionResult metric should not be counted for resources provided in data url form.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 1 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2f303eb3f571bd2e05de89de3aa08f15437e490

commit e2f303eb3f571bd2e05de89de3aa08f15437e490
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Jul 01 14:16:25 2016

WebFonts intervention: exclude data url from the intervention metrics

When WebFont resource is provided by data url, do not trigger the
intervention, and do not report MissCachedInterventionResult.

BUG= 625063 

Review-Url: https://codereview.chromium.org/2109353003
Cr-Commit-Position: refs/heads/master@{#403450}

[modify] https://crrev.com/e2f303eb3f571bd2e05de89de3aa08f15437e490/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/e2f303eb3f571bd2e05de89de3aa08f15437e490/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h

Components: Blink>WebFonts
Labels: -M-54 -MovedFrom-53 Merge-Request-53 M-53

Comment 4 by dimu@google.com, Jul 4 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 5 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e372fbc5ca85bf9a1ad8b9c896919572ffd315f

commit 4e372fbc5ca85bf9a1ad8b9c896919572ffd315f
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Jul 05 05:55:32 2016

WebFonts intervention: exclude data url from the intervention metrics

When WebFont resource is provided by data url, do not trigger the
intervention, and do not report MissCachedInterventionResult.

BUG= 625063 

Review-Url: https://codereview.chromium.org/2109353003
Cr-Commit-Position: refs/heads/master@{#403450}
(cherry picked from commit e2f303eb3f571bd2e05de89de3aa08f15437e490)

TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/2121033003 .

Cr-Commit-Position: refs/branch-heads/2785@{#16}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/4e372fbc5ca85bf9a1ad8b9c896919572ffd315f/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/4e372fbc5ca85bf9a1ad8b9c896919572ffd315f/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h

Status: Fixed (was: Started)
Labels: Needs-Feedback
toyoshim@ : Could you please let us know the steps to verify if it can be done from TE end.
Labels: -Needs-Feedback
This fix doesn't change user facing behaviors, but changes how to correct histogram data for us, and minor bahaviors behind a field trial expwriment.
toyoshim@ : Thank you for the update.

Sign in to add a comment