Issue 625060 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	llozano@chromium.org
Closed:	Aug 2016
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
Build-Toolchain VerifyIn-54

Blocking:
issue 537368

llvm: goma does not interact well with sysroot_wrapper for llvm when used in simple chrome

Project Member Reported by llozano@chromium.org, Jul 1 2016

Issue description

the sysroot_wrapper expect the user to specify the location of clang compiler when clang is not under /usr/bin/clang by setting the envvar CLANG. 
however, goma does not look at this envvar, so when executed under goma, the sysroot_wrapper does not see the value of envvar CLANG.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d0f6a29516e6759f9afc3db3c3bf74a576650527

commit d0f6a29516e6759f9afc3db3c3bf74a576650527
Author: Luis Lozano <llozano@chromium.org>
Date: Thu Jun 30 18:40:43 2016

sysroot_wrapper: use relative location for clang compiler

When the wrapper is used for clang in simple_chrome, the wrapper expects
the user to set the location of clang with envvar CLANG.
However, the goma wrapper does not propagate the value of this envvar to
the sysroot_wrapper.
To avoid this problem, we change the default location to be relative
to the location of the sysroot wrapper which is valid both within the
chroot and in the simple chrome environment.

BUG= chromium:625060 
TEST=cbuildbot --latest-toolchain daisy-release falco-release

Change-Id: I4a3f7cfc4a4fb4bc2b92830b892b29c979e25ae2
Reviewed-on: https://chromium-review.googlesource.com/357823
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/d0f6a29516e6759f9afc3db3c3bf74a576650527/sys-devel/gcc/files/sysroot_wrapper.hardened
[rename] https://crrev.com/d0f6a29516e6759f9afc3db3c3bf74a576650527/sys-devel/gcc/gcc-4.9.2-r131.ebuild