Compilation Error After Clobbering and Rebuild of ios_internal_unittest |
||||
Issue descriptionThe following error was hit when compiling after a clobber: ../../components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc:10:10: fatal error: 'components/data_reduction_proxy/core/common/version.h' file not found Likely has to do with these 2 upstream CLs: 19f51e4 Adding version info to the client config request by ryansturm https://chromium.googlesource.com/chromium/src/+/19f51e45ebccead8ad7df4b0bbaa66f783b506c8 5bba9e1 Refactoring client/version to util by ryansturm https://chromium.googlesource.com/chromium/src/+/5bba9e15186207d6e88aa1c43ee17230a6578c25 Did not get a chance to investigate further, so sending to sheriffs
,
Jul 1 2016
We should not be building components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc on iOS as Chrome on iOS no longer use data_reduction_proxy. The fix for iOS is to remove the dependency on data_reduction_proxy from the dependencies of components_unittests when is_ios is true by moving line 78 of src/components/BUILD.gn to line 177.
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ec6ed740a07768d0bbcb70605b576fea4edb8e7 commit 1ec6ed740a07768d0bbcb70605b576fea4edb8e7 Author: gambard <gambard@chromium.org> Date: Fri Jul 01 13:25:03 2016 Fix build dependence for data_reduction_proxy This CL fixes a dependence problem for building data_reduction_proxy with gyp. BUG= 625030 Review-Url: https://codereview.chromium.org/2111913004 Cr-Commit-Position: refs/heads/master@{#403445} [modify] https://crrev.com/1ec6ed740a07768d0bbcb70605b576fea4edb8e7/components/data_reduction_proxy.gypi
,
Jul 1 2016
Should be fixed by fixing the dependencies on data_reduction_proxy. For information, this happens only in gyp.
,
Aug 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/709b9154c27d8b99bdb32e7f82e575b2cd02d202 commit 709b9154c27d8b99bdb32e7f82e575b2cd02d202 Author: Jian Li <jianli@chromium.org> Date: Sat Aug 27 00:33:57 2016 Fix build dependence for data_reduction_proxy This CL fixes a dependence problem for building data_reduction_proxy with gyp. BUG= 625030 Review-Url: https://codereview.chromium.org/2111913004 Cr-Commit-Position: refs/heads/master@{#403445} (cherry picked from commit 1ec6ed740a07768d0bbcb70605b576fea4edb8e7) Review URL: https://codereview.chromium.org/2287823002 . Cr-Commit-Position: refs/branch-heads/2785@{#772} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/709b9154c27d8b99bdb32e7f82e575b2cd02d202/components/data_reduction_proxy.gypi |
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Jul 1 2016