Monochrome arm32 crash on NOTREACHED on start. |
|||||||||||
Issue descriptionHello, I found monochrome crashes with 07-01 03:11:09.093 24658 24658 F DEBUG : Abort message: '[FATAL:resource_bundle.cc(577)] Check failed: false. unable to find resource: 27985 on start if you enable DCHECK. Note that debug=false in my gn settings. Symbolized stack: DebugBreak at base/debug/debugger_posix.cc:219 logging::LogMessage::~LogMessage() at base/logging.cc:748 ui::ResourceBundle::GetLocalizedString(int) at ui/base/resource/resource_bundle.cc:564 (discriminator 11) l10n_util::GetStringUTF16(int) at ui/base/l10n/l10n_util.cc:681 l10n_util::GetStringUTF8(int) at ui/base/l10n/l10n_util.cc:676 PrefsTabHelper::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable*) at chrome/browser/ui/prefs/prefs_tab_helper.cc:538 (discriminator 1) chrome::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable*) at chrome/browser/prefs/browser_prefs.cc:452 ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) at chrome/browser/profiles/profile_impl.cc:464 (discriminator 1) Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) at chrome/browser/profiles/profile_impl.cc:318 (discriminator 2) ProfileManager::CreateProfileHelper(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:1253 ProfileManager::CreateAndInitializeProfile(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:1330 ProfileManager::GetProfile(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:432 ProfileManager::GetActiveUserOrOffTheRecordProfileFromPath(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:1296 ProfileManager::GetActiveUserProfile() at chrome/browser/profiles/profile_manager.cc:414 (discriminator 1) CreatePrimaryProfile at chrome/browser/chrome_browser_main.cc:406 ChromeBrowserMainParts::PreMainMessageLoopRun() at chrome/browser/chrome_browser_main.cc:1211 content::BrowserMainLoop::PreMainMessageLoopRun() at content/browser/browser_main_loop.cc:925 (discriminator 1) base::Callback<int (), (base::internal::CopyMode)1>::Run() const at base/callback.h:389 (discriminator 1) base::Callback<void (), (base::internal::CopyMode)1>::Run() const at base/callback.h:389 (discriminator 1) base::MessageLoop::RunTask(base::PendingTask const&) at base/message_loop/message_loop.cc:493 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) at base/message_loop/message_loop.cc:502 base::MessageLoop::DoWork() at base/message_loop/message_loop.cc:624 DoRunLoopOnce at base/message_loop/message_pump_android.cc:37
,
Jul 1 2016
This is an issue, it seemed someone added components_locale_settings to Chrome, but not to Monochrome, see https://codereview.chromium.org/1679283002 I will refactoring code to make sure it will not happen again.
,
Jul 1 2016
Also, we need to enable debug version ASAP
,
Jul 1 2016
hush@ nice catch, thanks
,
Jul 1 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/cd1b9303821f6880b3c8aed0b20bac6d87b7bbd9 commit cd1b9303821f6880b3c8aed0b20bac6d87b7bbd9 Author: Tao Bai <michaelbai@google.com> Date: Fri Jul 01 18:59:50 2016
,
Jul 1 2016
,
Jul 1 2016
[Automated comment] Request affecting a post-stable build (M51), manual review required.
,
Jul 1 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jul 1 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/f7b8c698a1e2897dcb1ed569e15cd887302130eb commit f7b8c698a1e2897dcb1ed569e15cd887302130eb Author: Tao Bai <michaelbai@google.com> Date: Fri Jul 01 18:59:50 2016
,
Jul 6 2016
,
Jul 6 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 6 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/f9f58dfe9cc66dab779413749fb7bd38c7e159cf commit f9f58dfe9cc66dab779413749fb7bd38c7e159cf Author: Tao Bai <michaelbai@google.com> Date: Fri Jul 01 18:59:50 2016
,
Jul 6 2016
I just did a fresh build (removed out/ directory) with the change. And I got this error consistently:
[72/130] ACTION //clank/java:monochrome_apk__process_resources(//build/toolchain/android:arm)
FAILED: gen/clank/java/monochrome_apk__process_resources.d gen/clank/java/monochrome_apk/monochrome_apk.resources.zip gen/clank/java/monochrome_apk__process_resources.srcjar gen/clank/java/monochrome_apk__process_resources_R.txt gen/clank/java/monochrome_apk/monochrome_apk.resources.all.zip gen/clank/java/monochrome_apk/monochrome_apk.resources.proguard.txt
python ../../build/android/gyp/process_resources.py --depfile gen/clank/java/monochrome_apk__process_resources.d --android-sdk-jar /usr/local/google/home/hush/code/chromium/src/clank/third_party/android_platform/webview/frameworks_master.jar --aapt-path /usr/local/google/home/hush/code/chromium/src/clank/third_party/android_tools/sdk/build-tools/android-NYC/aapt --android-manifest gen/monochrome_apk_manifest_monochrome_apk/AndroidManifest.xml --resource-dirs=\[\"../../build/android/ant/empty/res\"\] --srcjar-out gen/clank/java/monochrome_apk__process_resources.srcjar --resource-zip-out gen/clank/java/monochrome_apk/monochrome_apk.resources.zip --r-text-out gen/clank/java/monochrome_apk__process_resources_R.txt --dependencies-res-zips=@FileArg\(gen/clank/java/monochrome_apk.build_config:resources:dependency_zips\) --extra-res-packages=@FileArg\(gen/clank/java/monochrome_apk.build_config:resources:extra_package_names\) --extra-r-text-files=@FileArg\(gen/clank/java/monochrome_apk.build_config:resources:extra_r_text_files\) --app-as-shared-lib --all-resources-zip-out gen/clank/java/monochrome_apk/monochrome_apk.resources.all.zip --proguard-file gen/clank/java/monochrome_apk/monochrome_apk.resources.proguard.txt
Traceback (most recent call last):
File "../../build/android/gyp/process_resources.py", line 532, in <module>
main(sys.argv[1:])
File "../../build/android/gyp/process_resources.py", line 528, in main
force=options.R_dir)
File "/usr/local/google/home/hush/code/chromium/src/build/android/gyp/util/build_utils.py", line 527, in CallAndWriteDepfileIfStale
pass_changes=True)
File "/usr/local/google/home/hush/code/chromium/src/build/android/gyp/util/md5_check.py", line 60, in CallAndRecordIfStale
entries = _ExtractZipEntries(path)
File "/usr/local/google/home/hush/code/chromium/src/build/android/gyp/util/md5_check.py", line 404, in _ExtractZipEntries
with zipfile.ZipFile(path) as zip_file:
File "/usr/lib/python2.7/zipfile.py", line 756, in __init__
self.fp = open(file, modeDict[mode])
IOError: [Errno 2] No such file or directory: u'gen/clank/java/monochrome_locale_paks.resources.zip'
Any ideas?
,
Jul 6 2016
My gn args below: is_debug = false use_goma = true goma_dir = "/usr/local/google/home/hush/opt/goma" target_os = "android" target_cpu = "arm" dcheck_always_on = false use_webview_internal_framework = true use_unpublished_apis = true use_signing_keys = true unpublished_api_version = 24 is_component_build = false
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3be42fae02abfe223b6763389f73cc5b4510d1a9 commit 3be42fae02abfe223b6763389f73cc5b4510d1a9 Author: michaelbai <michaelbai@chromium.org> Date: Wed Jul 06 23:51:55 2016 Upstream monochrome repack locales Reuse chrome_repack_locales template and move webview specific pak file to a variable, so monochrome will not miss any change BUG= 625028 Review-Url: https://codereview.chromium.org/2124073002 Cr-Commit-Position: refs/heads/master@{#403986} [modify] https://crrev.com/3be42fae02abfe223b6763389f73cc5b4510d1a9/android_webview/webview_repack_locales.gni [add] https://crrev.com/3be42fae02abfe223b6763389f73cc5b4510d1a9/android_webview/webview_repack_locales_list.gni [add] https://crrev.com/3be42fae02abfe223b6763389f73cc5b4510d1a9/chrome/android/monochrome_repack_locales.gni [modify] https://crrev.com/3be42fae02abfe223b6763389f73cc5b4510d1a9/chrome/chrome_repack_locales.gni
,
Jul 7 2016
#13: I opened crbug/626179 for that. let's discuss it there.
,
Jul 7 2016
RE #13, the error is not related to landed patch for this issue, the patch was cherry-picked to M52 in July 1st, and M52 release bot was green in July 3rd.
,
Jul 7 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/7a568b92bdaa45dcd88bbc0cacb2463592175af2 commit 7a568b92bdaa45dcd88bbc0cacb2463592175af2 Author: Tao Bai <michaelbai@google.com> Date: Thu Jul 07 19:51:40 2016
,
Jul 7 2016
Spoke with michaelbai@ offline, we don't need this for M51.
,
Jul 7 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by hush@chromium.org
, Jul 1 2016