New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Monochrome arm32 crash on NOTREACHED on start.

Project Member Reported by hush@chromium.org, Jul 1 2016

Issue description

Hello, I found monochrome crashes with
07-01 03:11:09.093 24658 24658 F DEBUG   : Abort message: '[FATAL:resource_bundle.cc(577)] Check failed: false. unable to find resource: 27985
on start if you enable DCHECK. Note that debug=false in my gn settings.

Symbolized stack:
DebugBreak at base/debug/debugger_posix.cc:219

logging::LogMessage::~LogMessage() at base/logging.cc:748

ui::ResourceBundle::GetLocalizedString(int) at ui/base/resource/resource_bundle.cc:564 (discriminator 11)

l10n_util::GetStringUTF16(int) at ui/base/l10n/l10n_util.cc:681

l10n_util::GetStringUTF8(int) at ui/base/l10n/l10n_util.cc:676

PrefsTabHelper::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable*) at chrome/browser/ui/prefs/prefs_tab_helper.cc:538 (discriminator 1)

chrome::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable*) at chrome/browser/prefs/browser_prefs.cc:452

ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) at chrome/browser/profiles/profile_impl.cc:464 (discriminator 1)

Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) at chrome/browser/profiles/profile_impl.cc:318 (discriminator 2)

ProfileManager::CreateProfileHelper(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:1253

ProfileManager::CreateAndInitializeProfile(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:1330

ProfileManager::GetProfile(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:432

ProfileManager::GetActiveUserOrOffTheRecordProfileFromPath(base::FilePath const&) at chrome/browser/profiles/profile_manager.cc:1296

ProfileManager::GetActiveUserProfile() at chrome/browser/profiles/profile_manager.cc:414 (discriminator 1)

CreatePrimaryProfile at chrome/browser/chrome_browser_main.cc:406

ChromeBrowserMainParts::PreMainMessageLoopRun() at chrome/browser/chrome_browser_main.cc:1211

content::BrowserMainLoop::PreMainMessageLoopRun() at content/browser/browser_main_loop.cc:925 (discriminator 1)

base::Callback<int (), (base::internal::CopyMode)1>::Run() const at base/callback.h:389 (discriminator 1)

base::Callback<void (), (base::internal::CopyMode)1>::Run() const at base/callback.h:389 (discriminator 1)

base::MessageLoop::RunTask(base::PendingTask const&) at base/message_loop/message_loop.cc:493

base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) at base/message_loop/message_loop.cc:502

base::MessageLoop::DoWork() at base/message_loop/message_loop.cc:624

DoRunLoopOnce at base/message_loop/message_pump_android.cc:37

 

Comment 1 by hush@chromium.org, Jul 1 2016

Cc: michaelbai@chromium.org sgu...@chromium.org torne@chromium.org
So, resource 27985 is IDS_ACCEPT_LANGUAGES defined in 
https://cs.chromium.org/chromium/src/out/Debug/gen/components/strings/grit/components_locale_settings.h?rcl=0&l=6

In fact, I logged IDS_DEFAULT_ENCODING and it's an empty string too.

We're failing in this file:
https://cs.chromium.org/chromium/src/chrome/browser/ui/prefs/prefs_tab_helper.cc?rcl=1467314518&l=535

  registry->RegisterStringPref(
      prefs::kAcceptLanguages,
      l10n_util::GetStringUTF8(IDS_ACCEPT_LANGUAGES),
      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
  registry->RegisterStringPref(
      prefs::kDefaultCharset,
      l10n_util::GetStringUTF8(IDS_DEFAULT_ENCODING),
      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);


So... is this a problem for us?
Owner: michaelbai@chromium.org
Status: Assigned (was: Untriaged)
This is an issue, it seemed someone added components_locale_settings to Chrome, but not to Monochrome, see

https://codereview.chromium.org/1679283002

I will refactoring code to make sure it will not happen again.
Also, we need to enable debug version ASAP
hush@ nice catch, thanks
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/cd1b9303821f6880b3c8aed0b20bac6d87b7bbd9

commit cd1b9303821f6880b3c8aed0b20bac6d87b7bbd9
Author: Tao Bai <michaelbai@google.com>
Date: Fri Jul 01 18:59:50 2016

Cc: amineer@chromium.org
Labels: Merge-Request-52 Merge-Request-51

Comment 7 by dimu@google.com, Jul 1 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M51), manual review required.

Comment 8 by dimu@google.com, Jul 1 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 1 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/f7b8c698a1e2897dcb1ed569e15cd887302130eb

commit f7b8c698a1e2897dcb1ed569e15cd887302130eb
Author: Tao Bai <michaelbai@google.com>
Date: Fri Jul 01 18:59:50 2016

Labels: Merge-Request-53

Comment 11 by dimu@google.com, Jul 6 2016

Labels: -Merge-Request-53 Merge-Approved-53
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 6 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/f9f58dfe9cc66dab779413749fb7bd38c7e159cf

commit f9f58dfe9cc66dab779413749fb7bd38c7e159cf
Author: Tao Bai <michaelbai@google.com>
Date: Fri Jul 01 18:59:50 2016

Comment 13 by hush@chromium.org, Jul 6 2016

I just did a fresh build (removed out/ directory) with the change. And I got this error consistently:
[72/130] ACTION //clank/java:monochrome_apk__process_resources(//build/toolchain/android:arm)
FAILED: gen/clank/java/monochrome_apk__process_resources.d gen/clank/java/monochrome_apk/monochrome_apk.resources.zip gen/clank/java/monochrome_apk__process_resources.srcjar gen/clank/java/monochrome_apk__process_resources_R.txt gen/clank/java/monochrome_apk/monochrome_apk.resources.all.zip gen/clank/java/monochrome_apk/monochrome_apk.resources.proguard.txt 
python ../../build/android/gyp/process_resources.py --depfile gen/clank/java/monochrome_apk__process_resources.d --android-sdk-jar /usr/local/google/home/hush/code/chromium/src/clank/third_party/android_platform/webview/frameworks_master.jar --aapt-path /usr/local/google/home/hush/code/chromium/src/clank/third_party/android_tools/sdk/build-tools/android-NYC/aapt --android-manifest gen/monochrome_apk_manifest_monochrome_apk/AndroidManifest.xml --resource-dirs=\[\"../../build/android/ant/empty/res\"\] --srcjar-out gen/clank/java/monochrome_apk__process_resources.srcjar --resource-zip-out gen/clank/java/monochrome_apk/monochrome_apk.resources.zip --r-text-out gen/clank/java/monochrome_apk__process_resources_R.txt --dependencies-res-zips=@FileArg\(gen/clank/java/monochrome_apk.build_config:resources:dependency_zips\) --extra-res-packages=@FileArg\(gen/clank/java/monochrome_apk.build_config:resources:extra_package_names\) --extra-r-text-files=@FileArg\(gen/clank/java/monochrome_apk.build_config:resources:extra_r_text_files\) --app-as-shared-lib --all-resources-zip-out gen/clank/java/monochrome_apk/monochrome_apk.resources.all.zip --proguard-file gen/clank/java/monochrome_apk/monochrome_apk.resources.proguard.txt
Traceback (most recent call last):
  File "../../build/android/gyp/process_resources.py", line 532, in <module>
    main(sys.argv[1:])
  File "../../build/android/gyp/process_resources.py", line 528, in main
    force=options.R_dir)
  File "/usr/local/google/home/hush/code/chromium/src/build/android/gyp/util/build_utils.py", line 527, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/usr/local/google/home/hush/code/chromium/src/build/android/gyp/util/md5_check.py", line 60, in CallAndRecordIfStale
    entries = _ExtractZipEntries(path)
  File "/usr/local/google/home/hush/code/chromium/src/build/android/gyp/util/md5_check.py", line 404, in _ExtractZipEntries
    with zipfile.ZipFile(path) as zip_file:
  File "/usr/lib/python2.7/zipfile.py", line 756, in __init__
    self.fp = open(file, modeDict[mode])
IOError: [Errno 2] No such file or directory: u'gen/clank/java/monochrome_locale_paks.resources.zip'


Any ideas?

Comment 14 by hush@chromium.org, Jul 6 2016

My gn args below:

is_debug = false
use_goma = true
goma_dir = "/usr/local/google/home/hush/opt/goma"
target_os = "android"
target_cpu = "arm"
dcheck_always_on = false
use_webview_internal_framework = true
use_unpublished_apis = true
use_signing_keys = true
unpublished_api_version = 24
is_component_build = false
#13: I opened crbug/626179 for that. let's discuss it there.
RE #13, the error is not related to landed patch for this issue, the patch was cherry-picked to M52 in July 1st, and M52 release bot was green in July 3rd.
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/7a568b92bdaa45dcd88bbc0cacb2463592175af2

commit 7a568b92bdaa45dcd88bbc0cacb2463592175af2
Author: Tao Bai <michaelbai@google.com>
Date: Thu Jul 07 19:51:40 2016

Labels: -Merge-Review-51
Spoke with michaelbai@ offline, we don't need this for M51.
Status: Fixed (was: Assigned)

Sign in to add a comment