Some crashes if there is no resources pack in content shell
Reported by
hyungwoo...@navercorp.com,
Jul 1 2016
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.60 Safari/537.36 Steps to reproduce the problem: 1. Remove content_shell.pak 2. Run content_shell.exe 3. What is the expected behavior? There is no crash while execute content_shell.exe What went wrong? There is no null check in some place. Crashed report ID: How much crashed? Just one tab Is it a problem with a plugin? N/A Did this work before? N/A Chrome version: 52.0.2743.60 Channel: n/a OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Jul 1 2016
,
Jul 8 2016
Hmm. I don't think we need content_shell to function without the resource file being available. Is this really a bug?
,
Jul 28 2016
@rnimmagadda It is related to content shell, hence there is no crash id for this case.
,
Jul 28 2016
I think content shell should not make crash even if there is no resource file. I've made patch for this as following. https://codereview.chromium.org/2117693002/
,
Aug 2 2016
Thanks for taking the time to submit a patch. It will really help to hear more about why this crash is important for you. Consider writing something like: I/we need the content_shell to function without the resource file because...<why>. or saying: In <this situation which I/we are facing> the resource file may not be available.
,
Aug 10 2016
Thank you for providing more feedback. Adding requester "rnimmagadda@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 11 2016
Actually I found this bug when I make new embedder of content layer such as content_shell. It was difficult to recognize the crash is related to resource file. When you successfully load content layer without resource file, you can easily recognize absences of resource file.
,
Aug 12 2016
@dschuyler: Could you please look into this as per the comment #8 Thank you.
,
Aug 12 2016
,
Aug 18 2016
Need to change OS to All
,
Feb 9 2017
Adding @dschuyler for more updates on this issue. Thanks!
,
Dec 15 2017
dschuyler@?
,
Dec 15 2017
#13 I see where this would be helpful to a developer, it's not high priority for most users. So I'm not going to mark this WontFix, but I'll lower the priority. This is a nice to have afaik. This may make a good 'first bug' for a new chrome developer: assuming it's about finding something akin to missing null check and reporting it. I expect that Chrome would sill exit (crash to a user's POV), but it could provide more error reporting to a developer (which I believe is the case for #8, based on "when I make new embedder of content layer such as content_shell" being something a developer does).
,
Jun 8 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rnimmagadda@chromium.org
, Jul 1 2016Labels: Needs-Feedback