New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625008 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Some crashes if there is no resources pack in content shell

Reported by hyungwoo...@navercorp.com, Jul 1 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.60 Safari/537.36

Steps to reproduce the problem:
1. Remove content_shell.pak
2. Run content_shell.exe
3. 

What is the expected behavior?
There is no crash while execute content_shell.exe

What went wrong?
There is no null check in some place.

Crashed report ID: 

How much crashed? Just one tab

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Chrome version: 52.0.2743.60  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 22.0 r0
 
Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
@hyungwook.lee: Could you please provide us the Crash ID [chrome://crashes] which would help us in triaging it further.

Thank you.
Components: Blink>Infra
Hmm. I don't think we need content_shell to function without the resource file being available. Is this really a bug?
@rnimmagadda It is related to content shell, hence there is no crash id for this case.

I think content shell should not make crash even if there is no resource file.

I've made patch for this as following.
https://codereview.chromium.org/2117693002/

Thanks for taking the time to submit a patch. It will really help to hear more about why this crash is important for you. Consider writing something like:

I/we need the content_shell to function without the resource file because...<why>.

or saying:

In <this situation which I/we are facing> the resource file may not be available.
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 10 2016

Labels: -Needs-Feedback Needs-Review
Owner: rnimmagadda@chromium.org
Thank you for providing more feedback. Adding requester "rnimmagadda@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Actually I found this bug when I make new embedder of content layer such as content_shell.

It was difficult to recognize the crash is related to resource file.

When you successfully load content layer without resource file, you can easily recognize absences of resource file.
Labels: -Needs-Review
Owner: ----
@dschuyler: Could you please look into this as per the comment #8

Thank you.
Labels: Needs-Feedback

Comment 11 by with...@gmail.com, Aug 18 2016

Need to change OS to All
Cc: dschuyler@chromium.org
Adding @dschuyler for more updates on this issue.

Thanks!
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
dschuyler@?
Labels: -Pri-2 Hotlist-GoodFirstBug Pri-3
Status: Available (was: Assigned)
#13 I see where this would be helpful to a developer, it's not high priority for most users. So I'm not going to mark this WontFix, but I'll lower the priority. This is a nice to have afaik.

This may make a good 'first bug' for a new chrome developer: assuming it's about finding something akin to missing null check and reporting it. I expect that Chrome would sill exit (crash to a user's POV), but it could provide more error reporting to a developer (which I believe is the case for #8, based on "when I make new embedder of content layer such as content_shell" being something a developer does).
Owner: ----

Sign in to add a comment