Infra tree is closed because of bad findit tests. |
|||
Issue descriptionNot sure what the problem is, but I'm going to disable the tests now. See https://build.chromium.org/p/chromium.infra/builders/infra-continuous-wily-64/builds/736 https://build.chromium.org/p/chromium.infra/builders/infra-continuous-trusty-64/builds/2762 https://build.chromium.org/p/chromium.infra/builders/infra-continuous-trusty-32/builds/2771 for examples.
,
Jul 1 2016
Please re-enable the tests when they aren't broken :)
,
Jul 1 2016
martiniss@: many thanks for disabling the test. Sharu, the tests seem like flaky, please fix them.
,
Jul 1 2016
It looks like it has something to do with json imports giving you unicode, which your tests might compare as inequal to your regular strings. But I'm not totally sure.
,
Jul 12 2016
martiniss@: many thanks! sorry for the delay, I somehow missed the email(probably because it's right before the holidays ><), upload a fix here https://codereview.chromium.org/2147773002
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/b6b2c25f84c821e3c20feb509c9d366ea30905f2 commit b6b2c25f84c821e3c20feb509c9d366ea30905f2 Author: katesonia <katesonia@chromium.org> Date: Wed Jul 13 00:11:07 2016 [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request. BUG= 624998 , 626511 Review-Url: https://codereview.chromium.org/2147773002 [modify] https://crrev.com/b6b2c25f84c821e3c20feb509c9d366ea30905f2/appengine/findit/handlers/crash/test/fracas_dashboard_test.py
,
Jul 19 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 1 2016