Issue 624988 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	█ allada@chromium.org Last visit > 30 days ago
Closed:	Jul 2016
Components:	Platform>DevTools>Network
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

[Devtools] Split NetworkLogview into multiple files

Project Member Reported by allada@chromium.org, Jun 30 2016

Issue description

NetworkLogview.js is very large and handles quite a bit of events/functions. We should split this file up into separate files for each segment.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f72580334bcbfe0fd4038dea65c2a1df910d31

commit 24f72580334bcbfe0fd4038dea65c2a1df910d31
Author: allada <allada@chromium.org>
Date: Thu Jul 07 19:12:33 2016

[Devtools] Seperate columns out of NetworkLogView into own file

NetworkLogView is a bit bloated. This patch is to seperate column
specific stuff out of NetworkLogView.js into it's file.

BUG= 624988 

Review-Url: https://codereview.chromium.org/2118663002
Cr-Commit-Position: refs/heads/master@{#404203}

[modify] https://crrev.com/24f72580334bcbfe0fd4038dea65c2a1df910d31/third_party/WebKit/Source/devtools/devtools.gypi
[modify] https://crrev.com/24f72580334bcbfe0fd4038dea65c2a1df910d31/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[add] https://crrev.com/24f72580334bcbfe0fd4038dea65c2a1df910d31/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/24f72580334bcbfe0fd4038dea65c2a1df910d31/third_party/WebKit/Source/devtools/front_end/network/module.json

Comment 2 by allada@chromium.org, Jul 22 2016

Status: Fixed (was: Assigned)

►

Issue 624988 link

Issue metadata

[Devtools] Split NetworkLogview into multiple files

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 7 2016

Comment 1 Deleted

Comment 2 by allada@chromium.org, Jul 22 2016

Comment 2 Deleted

Sign in to add a comment