Chrome Translation Bubble is not available in Incognito mode |
|||||||||||
Issue descriptionOS: ALL What steps will reproduce the problem? (1) In Incognito mode (2) Visit a web site which the language is not the same as the chrome UI language. What is the expected output? Translate bubble or infobar show up to prompt the user to translate. What do you see instead? Translate feature is not there.
,
Jun 30 2016
Actually, this bug is only on Linux and Windows on Bubble. It is not reproducible on Mac or Andriod/iOS OS: Linux / Windows
,
Jun 30 2016
This got introduced in https://codereview.chromium.org/345743002 The CL and the bug aren't clear on why we don't show the bubble in incognito any more. The TranslateInfoBar doesnt expose the same behavior, so I think it's safe to say we can remove that. Re c#2: Yes - infobar behavior is different. (Which we should probably address at some point...)
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/711aae13e655054eb44f00bcb246e717a425d27b commit 711aae13e655054eb44f00bcb246e717a425d27b Author: ftang <ftang@chromium.org> Date: Thu Jul 07 00:03:36 2016 Translate Bubble now honors the "IsTooOftenDenied" policy in incognito. BUG= 624984 Review-Url: https://codereview.chromium.org/2116653003 Cr-Commit-Position: refs/heads/master@{#403994} [modify] https://crrev.com/711aae13e655054eb44f00bcb246e717a425d27b/chrome/browser/translate/chrome_translate_client.cc
,
Jul 12 2016
,
Jul 12 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 12 2016
,
Jul 13 2016
groby- could you merge this into M53 for me? thanks
,
Jul 15 2016
Please merge your change to M53 branch 2785 ASAP (latest by 4:00 PM PST on Monday, 07/18) in order to make it to M53 dev release next week before Beta promotion.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4db15d2a7d909afae96e59563585d2bb23cfaf39 commit 4db15d2a7d909afae96e59563585d2bb23cfaf39 Author: Rachel Blum <groby@google.com> Date: Fri Jul 15 22:16:59 2016 [Merge M53] Translate Bubble now honors the "IsTooOftenDenied" policy in incognito. BUG= 624984 Review-Url: https://codereview.chromium.org/2116653003 Cr-Commit-Position: refs/heads/master@{#403994} (cherry picked from commit 711aae13e655054eb44f00bcb246e717a425d27b) Review URL: https://codereview.chromium.org/2153253002 . Cr-Commit-Position: refs/branch-heads/2785@{#166} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/4db15d2a7d909afae96e59563585d2bb23cfaf39/chrome/browser/translate/chrome_translate_client.cc
,
Jul 19 2016
Verified the merge on the latest M-53(53.0.2785.21) on Windows-7 and Linux Ubuntu 14.04 as per the test steps in C#0. Test URL: http://www.aljazeera.net/portal Chrome version: 53.0.2785.8(Before the CL was merged) > Translate bubble doesn't pop up but translate feature is available. Chrome version: 53.0.2785.21(After the CL was merged) > Translate bubble pops up and translate feature is available. ftang@: Could you please confirm if the fix is related to translate bubble not popping up or translate feature not available at all in incognito mode.
,
Jul 19 2016
YES
,
Jul 19 2016
Thanks for confirmation. Adding the verified label therefore.
,
Jul 26 2016
,
Apr 27 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by ftang@chromium.org
, Jun 30 2016This is caused by + if (!triggered_from_menu) { + if (web_contents()->GetBrowserContext()->IsOffTheRecord()) + return; https://chromium.googlesource.com/chromium/src/+/e1a99e3be662c7e9d6c1066f312211063166c361%5E%21/#F0 inside chrome/browser/translate/chrome_translate_client.cc