New issue
Advanced search Search tips

Issue 624958 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 456420

Blocking:
issue 791225



Sign in to add a comment

InputImeApiTest.SendKeyEvntsOnNormalPage failing on Site Isolation Linux FYI bot

Project Member Reported by creis@chromium.org, Jun 30 2016

Issue description

After azurewei's https://codereview.chromium.org/2077783002 landed, the Site Isolation Linux FYI bot started failing the new InputImeApiTest.SendKeyEvntsOnNormalPage test.

https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/9749

This bot runs tests with the --site-per-process flag to enable out-of-process iframes for cross-site pages.

Can you take a look?  We should either revert or disable the test soon.  Thanks!


InputImeApiTest.SendKeyEvntsOnNormalPage (run #1):
[ RUN      ] InputImeApiTest.SendKeyEvntsOnNormalPage
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[8534:8534:0630/135032:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[8534:8706:0630/135032:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[8534:8534:0630/135033:WARNING:render_frame_host_impl.cc(1949)] OnDidStopLoading was called twice.
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] testActivateAndFocus", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] testNormalCreateWindow", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] testFollowCursorCreateWindow", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] testCommitText", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] testSetComposition", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] testSendKeyEvents", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] testBlur", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
../../chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc:137: Failure
Value of: CompareKeyEvents(key_events, input_method)
  Actual: false
Expected: true
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[FAIL] (no test): lastError.message == Could not send key events
Error
    at null.<anonymous> (extensions::test:106:11)
    at null.handleRequest (extensions::binding:63:27)
    at null.<anonymous> (extensions::binding:422:32)
    at null.<anonymous> (extensions::test:225:18)
    at null.handleRequest (extensions::binding:63:27)
    at null.<anonymous> (extensions::binding:422:32)
    at null.callback (chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/background.js:104:19)
    at safeCallbackApply (extensions::sendRequest:21:15)
    at handleResponse (extensions::sendRequest:74:7)", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:WARNING:message_queue.cc(38)] Leaking 2 ports in unreceived messages
[8534:8534:0630/135034:INFO:CONSOLE(0)] "[SUCCESS] (no test)", source: chrome-extension://kcjodlobfnoldmijmapidkenggdpbnnn/_generated_background_page.html (0)
[8534:8534:0630/135034:WARNING:message_queue.cc(38)] Leaking 1 ports in unreceived messages
[8534:8534:0630/135034:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize
[8534:8534:0630/135034:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated
[8534:8534:0630/135034:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown printing.enabled
[  FAILED  ] InputImeApiTest.SendKeyEvntsOnNormalPage, where TypeParam =  and GetParam() =  (2551 ms)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4c2fa7989f86eb44c08d0eb63060d2b17bf2f71

commit c4c2fa7989f86eb44c08d0eb63060d2b17bf2f71
Author: creis <creis@chromium.org>
Date: Thu Jun 30 23:35:42 2016

Disable InputImeApiTest.SendKeyEvntsOnNormalPage on Site Isolation FYI.

BUG=624958
NOTRY=true

Review-Url: https://codereview.chromium.org/2113813003
Cr-Commit-Position: refs/heads/master@{#403340}

[modify] https://crrev.com/c4c2fa7989f86eb44c08d0eb63060d2b17bf2f71/testing/buildbot/filters/site-per-process.browser_tests.filter

Comment 2 by creis@chromium.org, Jul 1 2016

@azurewei: Could you please look into this test on --site-per-process so that we can get it re-enabled on the FYI bot?
creis@, I'm working on finding the failure reason. Will fix this ASAP.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923f91436b01b92825d1998f18b344d151850ad3

commit 923f91436b01b92825d1998f18b344d151850ad3
Author: azurewei <azurewei@chromium.org>
Date: Mon Jul 04 06:30:31 2016

InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.

This test is used to test that input.ime.sendKeyEvents API has limitations on some special pages. It fails on Site Isolation Linux FYI bot, as the test fails to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test environment. It tests under GURL(kChromeSearchLocalNtpUrl): chrome-search://local-ntp/local-ntp.html, which is special page for input.ime.sendKeyEvents.

Fix this by not testing the API if the url has not been correctly set.

BUG=624958
TEST=None

Review-Url: https://codereview.chromium.org/2120823003
Cr-Commit-Position: refs/heads/master@{#403641}

[modify] https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3/chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc
[modify] https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3/testing/buildbot/filters/site-per-process.browser_tests.filter

Comment 5 by creis@chromium.org, Jul 6 2016

Blockedon: 456420
Cc: azurewei@chromium.org
Owner: creis@chromium.org
Sounds like this test is blocked on the NTP problems in issue 456420.  Let's revert r403641 and leave it disabled until that bug is fixed, and hopefully we can turn it back on after that.

I'll take ownership of re-enabling it when issue 456420 is fixed.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ca6e4ad757d0073e2e3de255dc10ca92a91a843

commit 2ca6e4ad757d0073e2e3de255dc10ca92a91a843
Author: azurewei <azurewei@chromium.org>
Date: Thu Jul 07 05:52:16 2016

Revert of Fix InputImeApiTest.SendKeyEventsOnNormalPage trybot failure. (patchset #4 id:60001 of https://codereview.chromium.org/2120823003/ )

Reason for revert:
Revert the working around.
The bug has been marked as blocked on bug:456420.

Original issue's description:
> InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.
>
> This test is used to test that input.ime.sendKeyEvents API has limitations on some special pages. It fails on Site Isolation Linux FYI bot, as the test fails to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test environment. It tests under GURL(kChromeSearchLocalNtpUrl): chrome-search://local-ntp/local-ntp.html, which is special page for input.ime.sendKeyEvents.
>
> Fix this by not testing the API if the url has not been correctly set.
>
> BUG=624958
> TEST=None
>
> Committed: https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3
> Cr-Commit-Position: refs/heads/master@{#403641}

TBR=shuchen@chromium.org,rdevlin.cronin@chromium.org,creis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=624958

Review-Url: https://codereview.chromium.org/2125243002
Cr-Commit-Position: refs/heads/master@{#404088}

[modify] https://crrev.com/2ca6e4ad757d0073e2e3de255dc10ca92a91a843/chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc
[modify] https://crrev.com/2ca6e4ad757d0073e2e3de255dc10ca92a91a843/testing/buildbot/filters/site-per-process.browser_tests.filter

Comment 7 by creis@chromium.org, Nov 18 2017

Labels: -Pri-1 Pri-2

Comment 8 by nasko@chromium.org, Dec 2 2017

Blocking: 791225
Labels: Hotlist-DesktopUIChecked
***UI Mass Triage ***

If there is no pending work, please feel free to close the issue.

Sign in to add a comment