"net_unittests" is flaky |
|||||
Issue description"net_unittests" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 12 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyGAsSBUZsYWtlIg1uZXRfdW5pdHRlc3RzDA. This flaky test/step was previously tracked in issue 610553 .
,
Jul 1 2016
lgarron@ - Please fix the tests or triage to someone that can. I'm going to disable the tests on ios.
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ee69ff4ed0c404daefaf868e8b6fa8dd778d911 commit 5ee69ff4ed0c404daefaf868e8b6fa8dd778d911 Author: magjed <magjed@chromium.org> Date: Fri Jul 01 14:42:49 2016 Disable tests OptionalHSTSCertPins and PreloadedPins on iOS BUG= 624946 TBR=asanka Review-Url: https://codereview.chromium.org/2113993002 Cr-Commit-Position: refs/heads/master@{#403454} [modify] https://crrev.com/5ee69ff4ed0c404daefaf868e8b6fa8dd778d911/net/http/transport_security_state_unittest.cc
,
Jul 1 2016
,
Jul 1 2016
This was fixed the same night (2 days ago) by https://chromium.googlesource.com/chromium/src/+/7413eece111784b09a8ef1abe88903237fd38df0 asanka@, is it safe to un-disable the unit tests, or was the some kind of roll that picked up the broken commit but not the fixed one?
,
Nov 23 2016
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af6a83f7d4c7b74320fa521e5f1630261ddaf0ac commit af6a83f7d4c7b74320fa521e5f1630261ddaf0ac Author: Martijn Croonen <martijnc@chromium.org> Date: Mon Oct 30 20:17:37 2017 Re-enable pinning tests on iOS. Bug: 624946 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4521dda8e15afb4c724432f99963aa8d83410503 Reviewed-on: https://chromium-review.googlesource.com/743010 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Martijn Croonen <martijnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#512594} [modify] https://crrev.com/af6a83f7d4c7b74320fa521e5f1630261ddaf0ac/net/http/transport_security_state_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by magjed@chromium.org
, Jul 1 2016The tests: TransportSecurityStateTest.OptionalHSTSCertPins TransportSecurityStateTest.PreloadedPins seem to be flaky on ios-simulator and ios-simulator-gn. They are failing with: TransportSecurityStateTest.OptionalHSTSCertPins: ../../net/http/transport_security_state_unittest.cc:1213: Failure Value of: StaticShouldRedirect("www.google-analytics.com") Actual: true Expected: false TransportSecurityStateTest.PreloadedPins: ../../net/http/transport_security_state_unittest.cc:1057: Failure Value of: OnlyPinningInStaticState("www.google-analytics.com") Actual: false Expected: true