New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624928 link

Starred by 1 user
Status: Fixed
Owner:
█ kateso...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ mmand...@chromium.org
mbarbe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 609621


Sign in to add a comment

[Predator-Fracas] Surface suspected components and suspected project.

Project Member Reported by kateso...@chromium.org, Jun 30 2016 
[Findit-Fracas] Surface suspected components and suspected project.

Findit has suspected components and suspected project results after the classifiers got enabled a while ago.

Since these 2 classification results are useful to sheriffs, we should surface the classification results to Fracas.

Comment 1 by kateso...@chromium.org, Jul 11 2016

Blockedon: 609621
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bf641fc0f205214cc03c192f1e1473465630507f

commit bf641fc0f205214cc03c192f1e1473465630507f
Author: katesonia <katesonia@chromium.org>
Date: Thu Jul 21 23:14:21 2016

[Findit] Pass changed files info to Fracas, 2 face design.

Message format from Findit to Fracas (updated in red at the bottom of the document https://docs.google.com/document/d/1fDhJ2suyTsCLXukJwNDqtTAx_hK0hjHrOuUFFR_jDtE/edit#heading=h.o9pruw3u1jti)
(1)Added changed files info to results
(2)changed reason from a str to a list of tuple explaining the scores.

Split previous aggregator.py into aggregators.py and aggregated_scorer.py. Add ChangedFilesAggregator.

Fix some old tests due to the changes.

BUG= 624928 ,  609621 

Review-Url: https://codereview.chromium.org/2157433002

[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/callstack.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/findit_for_crash.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/parse_util.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/results.py
[add] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/aggregated_scorer.py
[delete] https://crrev.com/ed2d821a5d2acc248419b48cbf6a032a3a2a65f0/appengine/findit/crash/scorers/aggregator.py
[add] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/aggregators.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/min_distance.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/scorer.py
[add] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/test/aggregated_scorer_test.py
[delete] https://crrev.com/ed2d821a5d2acc248419b48cbf6a032a3a2a65f0/appengine/findit/crash/scorers/test/aggregator_test.py
[add] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/test/aggregators_test.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/test/min_distance_test.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/test/top_frame_index_test.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/scorers/top_frame_index.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/test/callstack_test.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/test/crash_test_suite.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/test/findit_for_crash_test.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/test/parse_util_test.py
[modify] https://crrev.com/bf641fc0f205214cc03c192f1e1473465630507f/appengine/findit/crash/test/results_test.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e9c78ef32eb9f14eda83c20b8e47721b31ec3265

commit e9c78ef32eb9f14eda83c20b8e47721b31ec3265
Author: katesonia <katesonia@chromium.org>
Date: Fri Jul 29 18:36:52 2016

[Findit]Post-process findit-to-fracas results.

(1) Add feedback_url to crash analysis.
(2) Delete 'reason' in each suspected cl.

BUG= 624928 ,  609621 

Review-Url: https://codereview.chromium.org/2168173003

[modify] https://crrev.com/e9c78ef32eb9f14eda83c20b8e47721b31ec3265/appengine/findit/crash/fracas_crash_pipeline.py
[modify] https://crrev.com/e9c78ef32eb9f14eda83c20b8e47721b31ec3265/appengine/findit/crash/test/fracas_crash_pipeline_test.py

Comment 4 by lafo...@chromium.org, Jan 3 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
This owner is not able to receive e-mails, please re-triage.

Comment 5 by st...@chromium.org, Apr 24 2017

Cc: -jchin...@chromium.org -kateso...@chromium.org
Components: -Tools>Test>FindIt Tools>Test>Predator
Owner: kateso...@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by st...@chromium.org, Apr 24 2017

Labels: -Hotlist-Recharge-BouncingOwner

Comment 7 by st...@chromium.org, Apr 24 2017

Summary: [Predator-Fracas] Surface suspected components and suspected project. (was: [Findit-Fracas] Surface suspected components and suspected project.)

Comment 8 by kateso...@chromium.org, May 15 2017

Status: Fixed (was: Assigned)
This is already done long time ago.
►

Sign in to add a comment