^^^^
http://crrev.com/2116583002
After removing left padding from the list if icons.
Using margins instead of paddings for server card label, card icon list, and dropdowns.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c0897f84b3907e48ea75c1a8df6558134f28bea commit 6c0897f84b3907e48ea75c1a8df6558134f28bea Author: rouslan <rouslan@chromium.org> Date: Fri Jul 15 22:11:13 2016 Credit card editor for PaymentRequest UI. When user taps on an incomplete autofill credit card or [+ ADD CARD] button, the card editor launches. For server cards, the editor shows uneditable card information and lets the user set the billing address. For local cards, the editor shows the following fields. 1) A list of icons for supported card types. 2) The card number input with Luhn validation and formatting. Required field. 3) The name on card input. Required field. 4) The month and year dropdowns. January of this year by default for new cards. 5) The billing address dropdown with only complete addresses on disk and an option to add a new address. Required field. 6) A checkbox for saving the new card on disk. Checked by default, so it behaves similar to autofill settings. BUG= 624924 Review-Url: https://codereview.chromium.org/2116583002 Cr-Commit-Position: refs/heads/master@{#405876} [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-hdpi/pr_dinersclub.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-hdpi/pr_jcb.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-hdpi/pr_unionpay.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-mdpi/pr_dinersclub.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-mdpi/pr_jcb.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-mdpi/pr_unionpay.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xhdpi/pr_dinersclub.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xhdpi/pr_jcb.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xhdpi/pr_unionpay.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xxhdpi/pr_dinersclub.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xxhdpi/pr_jcb.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xxhdpi/pr_unionpay.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xxxhdpi/pr_dinersclub.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xxxhdpi/pr_jcb.png [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/drawable-xxxhdpi/pr_unionpay.png [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/layout/payment_request_editor_dropdown.xml [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/layout/payment_request_editor_icons.xml [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/layout/payment_request_editor_label.xml [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Validatable.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java [add] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/java_sources.gni [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/browser/android/resource_id.h [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/browser/autofill/android/personal_data_manager_android.h [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/chrome/test/data/android/payments/no_shipping.js [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/components/autofill/core/browser/payments/full_card_request.cc [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/components/autofill/core/browser/payments/full_card_request.h [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/components/autofill_strings.grdp [modify] https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea/components/resources/autofill_scaled_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/097480da90d9a2b752b603ab3e1d7daa198af65f commit 097480da90d9a2b752b603ab3e1d7daa198af65f Author: lizeb <lizeb@chromium.org> Date: Mon Jul 18 10:14:29 2016 Revert of Credit card editor for PaymentRequest UI. (patchset #5 id:490001 of https://codereview.chromium.org/2116583002/ ) Reason for revert: Broke Android Tests (dbg). BUG= 629011 , 624924 Original issue's description: > Credit card editor for PaymentRequest UI. > > When user taps on an incomplete autofill credit card or [+ ADD CARD] > button, the card editor launches. > > For server cards, the editor shows uneditable card information and lets > the user set the billing address. > > For local cards, the editor shows the following fields. > > 1) A list of icons for supported card types. > > 2) The card number input with Luhn validation and formatting. Required > field. > > 3) The name on card input. Required field. > > 4) The month and year dropdowns. January of this year by default for new > cards. > > 5) The billing address dropdown with only complete addresses on disk and > an option to add a new address. Required field. > > 6) A checkbox for saving the new card on disk. Checked by default, > so it behaves similar to autofill settings. > > BUG= 624924 > > Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea > Cr-Commit-Position: refs/heads/master@{#405876} TBR=mathp@chromium.org,dfalcantara@chromium.org,estade@chromium.org,rouslan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2158783002 Cr-Commit-Position: refs/heads/master@{#405971} [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-hdpi/pr_dinersclub.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-hdpi/pr_jcb.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-hdpi/pr_unionpay.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-mdpi/pr_dinersclub.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-mdpi/pr_jcb.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-mdpi/pr_unionpay.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xhdpi/pr_dinersclub.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xhdpi/pr_jcb.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xhdpi/pr_unionpay.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxhdpi/pr_dinersclub.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxhdpi/pr_jcb.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxhdpi/pr_unionpay.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxxhdpi/pr_dinersclub.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxxhdpi/pr_jcb.png [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/drawable-xxxhdpi/pr_unionpay.png [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/res/layout/payment_request_editor_dropdown.xml [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/layout/payment_request_editor_icons.xml [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/res/layout/payment_request_editor_label.xml [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Validatable.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java [delete] https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/java_sources.gni [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/browser/android/resource_id.h [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/browser/autofill/android/personal_data_manager_android.h [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/chrome/test/data/android/payments/no_shipping.js [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/autofill/core/browser/payments/full_card_request.cc [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/autofill/core/browser/payments/full_card_request.h [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/autofill_strings.grdp [modify] https://crrev.com/097480da90d9a2b752b603ab3e1d7daa198af65f/components/resources/autofill_scaled_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80b5895d9b722eba9129c62c1788f8cbef351dc4 commit 80b5895d9b722eba9129c62c1788f8cbef351dc4 Author: rouslan <rouslan@chromium.org> Date: Mon Jul 18 18:11:00 2016 Credit card editor for PaymentRequest UI. When user taps on an incomplete autofill credit card or [+ ADD CARD] button, the card editor launches. For server cards, the editor shows uneditable card information and lets the user set the billing address. For local cards, the editor shows the following fields. 1) A list of icons for supported card types. 2) The card number input with Luhn validation and formatting. Required field. 3) The name on card input. Required field. 4) The month and year dropdowns. January of this year by default for new cards. 5) The billing address dropdown with only complete addresses on disk and an option to add a new address. Required field. 6) A checkbox for saving the new card on disk. Checked by default, so it behaves similar to autofill settings. BUG= 624924 Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea Review-Url: https://codereview.chromium.org/2116583002 Cr-Original-Commit-Position: refs/heads/master@{#405876} Cr-Commit-Position: refs/heads/master@{#406036} [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-hdpi/pr_dinersclub.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-hdpi/pr_jcb.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-hdpi/pr_unionpay.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-mdpi/pr_dinersclub.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-mdpi/pr_jcb.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-mdpi/pr_unionpay.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xhdpi/pr_dinersclub.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xhdpi/pr_jcb.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xhdpi/pr_unionpay.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xxhdpi/pr_dinersclub.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xxhdpi/pr_jcb.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xxhdpi/pr_unionpay.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xxxhdpi/pr_dinersclub.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xxxhdpi/pr_jcb.png [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/drawable-xxxhdpi/pr_unionpay.png [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/layout/payment_request_editor_dropdown.xml [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/layout/payment_request_editor_icons.xml [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/layout/payment_request_editor_label.xml [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Validatable.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java [add] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/java_sources.gni [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/browser/android/resource_id.h [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/browser/autofill/android/personal_data_manager_android.h [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/chrome/test/data/android/payments/no_shipping.js [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/components/autofill/core/browser/payments/full_card_request.cc [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/components/autofill/core/browser/payments/full_card_request.h [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/components/autofill_strings.grdp [modify] https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4/components/resources/autofill_scaled_resources.grdp
Would like to merge 80b5895d9b722eba9129c62c1788f8cbef351dc4 to M-53.
Your change meets the bar and is auto-approved for M53 (branch: 2785)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd5f99f58ab6cc260f78f9b07d530181bac71b59 commit fd5f99f58ab6cc260f78f9b07d530181bac71b59 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Jul 19 16:39:51 2016 [Merge M-53] Credit card editor for PaymentRequest UI. When user taps on an incomplete autofill credit card or [+ ADD CARD] button, the card editor launches. For server cards, the editor shows uneditable card information and lets the user set the billing address. For local cards, the editor shows the following fields. 1) A list of icons for supported card types. 2) The card number input with Luhn validation and formatting. Required field. 3) The name on card input. Required field. 4) The month and year dropdowns. January of this year by default for new cards. 5) The billing address dropdown with only complete addresses on disk and an option to add a new address. Required field. 6) A checkbox for saving the new card on disk. Checked by default, so it behaves similar to autofill settings. BUG= 624924 Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea Review-Url: https://codereview.chromium.org/2116583002 Cr-Original-Commit-Position: refs/heads/master@{#405876} Cr-Commit-Position: refs/heads/master@{#406036} (cherry picked from commit 80b5895d9b722eba9129c62c1788f8cbef351dc4) Review URL: https://codereview.chromium.org/2163693002 . Cr-Commit-Position: refs/branch-heads/2785@{#218} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-hdpi/pr_dinersclub.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-hdpi/pr_jcb.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-hdpi/pr_unionpay.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-mdpi/pr_dinersclub.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-mdpi/pr_jcb.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-mdpi/pr_unionpay.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xhdpi/pr_dinersclub.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xhdpi/pr_jcb.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xhdpi/pr_unionpay.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xxhdpi/pr_dinersclub.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xxhdpi/pr_jcb.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xxhdpi/pr_unionpay.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xxxhdpi/pr_dinersclub.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xxxhdpi/pr_jcb.png [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/drawable-xxxhdpi/pr_unionpay.png [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/layout/payment_request_editor_dropdown.xml [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/layout/payment_request_editor_icons.xml [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/layout/payment_request_editor_label.xml [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Validatable.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java [add] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/java_sources.gni [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/browser/android/resource_id.h [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/browser/autofill/android/personal_data_manager_android.h [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/chrome/test/data/android/payments/no_shipping.js [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/components/autofill/core/browser/payments/full_card_request.cc [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/components/autofill/core/browser/payments/full_card_request.h [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/components/autofill_strings.grdp [modify] https://crrev.com/fd5f99f58ab6cc260f78f9b07d530181bac71b59/components/resources/autofill_scaled_resources.grdp
Comment 1 by rouslan@chromium.org
, Jun 30 2016