New issue
Advanced search Search tips

Issue 624923 link

Starred by 1 user
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Jul 2016
Cc:
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Pull ExtensionId into its own file

Project Member Reported by rdevlin....@chromium.org, Jun 30 2016 
ExtensionId is a typedefed std::string.  It's useful because a) it's self-documenting and b) if we ever decide to change the type of an extension id to something else, there's a few less places.  But having it declared in extension.h means that things that include it are bloated.  It should be in  its own file for lightweight inclusion.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0670b56616459deff22dd55d348dd804fe6a5195

commit 0670b56616459deff22dd55d348dd804fe6a5195
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Sat Jul 02 02:05:43 2016

[Extensions] Pull ExtensionId into its own file

Pull the typedef for ExtensionId into its own file so that includers
don't need the full extension.h include. Also fix a few IWYU errors,
though I'm sure there are many, many more.

BUG= 624923 
TBR=atwilson@chromium.org (c/b/background)
TBR=stevenjb@chromium.org (c/b/ui/app_list)

Review-Url: https://codereview.chromium.org/2106073006
Cr-Commit-Position: refs/heads/master@{#403590}

[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/background/background_mode_manager.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/api/automation_internal/automation_event_router.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/api/storage/sync_value_store_cache.cc
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/extension_management.cc
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/extension_management.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/extensions/extension_management_test_util.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/api/storage/local_value_store_cache.cc
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/content_hash_fetcher.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/process_manager.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/value_store/legacy_value_store_factory.cc
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/value_store/legacy_value_store_factory.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/value_store/test_value_store_factory.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/value_store/value_store_factory.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/browser/value_store/value_store_factory_impl.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/common/extension.h
[add] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/common/extension_id.h
[modify] https://crrev.com/0670b56616459deff22dd55d348dd804fe6a5195/extensions/extensions.gypi

Comment 2 by rdevlin....@chromium.org, Jul 6 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment