New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624898 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Bring Tab Share, Audio Share and New Picker UI to Default

Project Member Reported by qiangchen@chromium.org, Jun 30 2016

Issue description

We've developed the new features for desktop share:
1. Take a chrome tab as sharing source;
2. Share system audio or tab share with the other peer;
3. More user friendly picker window UI.

In M54, we will enable the feature for default, and removing deprecated code.
 
Cc: ainslie@chromium.org msw@chromium.org srcv@chromium.org blum@chromium.org
CODESOURCERY-MV_20110822-OSS.pdf
397 KB Download
Does this need a launch bug + review?
Re #3:
I think we've agreed the launch plan with test team.
blum@: Any additional step to launch the new feature?

Bug related with major feature developement:
crbug/602478  --- Picker UI
crbug/595428  --- Tab Sharing with Audio
crbug/557222  --- Tab Sharing
Labels: -Type-Bug Type-Feature
Labels: -Type-Feature Type-Launch
I think the major review work is done in crbug/557222 about the tab sharing with audio.
crbug/557222 tracks launch for tab sharing and crbug/618798 tracks the new UI. This should not be a launch bug.
Labels: -Type-Launch Type-Feature
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06a098504c69edf8a47b792da97e36ee807e4eb3

commit 06a098504c69edf8a47b792da97e36ee807e4eb3
Author: qiangchen <qiangchen@chromium.org>
Date: Fri Jul 08 17:19:12 2016

Make Desktop Capture New Feature Default On

We've finished the development of
1. Capturing a single chromium tab for desktop share
2. A new picker UI, which is more user friendly

During the developement, we hide the new feature behind a flag.
This CL makes the new feature default on.

BUG=557222,  624898 

Review-Url: https://codereview.chromium.org/2125063002
Cr-Commit-Position: refs/heads/master@{#404424}

[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/chrome/app/generated_resources.grd
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/chrome/browser/about_flags.cc
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/extensions/common/switches.cc
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/extensions/common/switches.h
[modify] https://crrev.com/06a098504c69edf8a47b792da97e36ee807e4eb3/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment