De-duplicate exact same fields values in suggestions |
||||||||
Issue descriptionIf you have a bunch of addresses with the same phone number and/or email address, de-duplication logic will not de-dupe them. Test site: https://rsolomakhin.github.io/pr/contact/ Repro steps: Add multiple profiles with the same phone number and email. Go to https://rsolomakhin.github.io/pr/contact/ and click "buy". See the duplicates in the list of contacts. When adding a new contact, see the duplicates in the list of suggestions.
,
Jul 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24fa769ff3ee4d66bc7867ae6f508636b372ef30 commit 24fa769ff3ee4d66bc7867ae6f508636b372ef30 Author: sebsg <sebsg@chromium.org> Date: Mon Jul 04 08:54:29 2016 [Payments] Dedupe contact info, and phone and email editor suggestions. BUG= 624869 Review-Url: https://codereview.chromium.org/2122493003 Cr-Commit-Position: refs/heads/master@{#403651} [modify] https://crrev.com/24fa769ff3ee4d66bc7867ae6f508636b372ef30/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/24fa769ff3ee4d66bc7867ae6f508636b372ef30/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/24fa769ff3ee4d66bc7867ae6f508636b372ef30/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/24fa769ff3ee4d66bc7867ae6f508636b372ef30/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
,
Jul 4 2016
,
Jul 4 2016
Don't mark fixed until merged into M-53, which is desired. Need to bake on trunk for a couple of days before requesting the merge.
,
Jul 6 2016
I'd like to merge this commit (24fa769ff3ee4d66bc7867ae6f508636b372ef30) associated with this CL (https://codereview.chromium.org/2122493003) into M-53. Thanks!
,
Jul 6 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82a6fca34d153cd12c3829aff8b39d803d148051 commit 82a6fca34d153cd12c3829aff8b39d803d148051 Author: sebsg <sebsg@chromium.org> Date: Wed Jul 06 11:17:14 2016 [Payments] Dedupe contact info, and phone and email editor suggestions. BUG= 624869 Review-Url: https://codereview.chromium.org/2122493003 Cr-Commit-Position: refs/heads/master@{#403651} (cherry picked from commit 24fa769ff3ee4d66bc7867ae6f508636b372ef30) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2123923002 Cr-Commit-Position: refs/branch-heads/2785@{#24} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/82a6fca34d153cd12c3829aff8b39d803d148051/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/82a6fca34d153cd12c3829aff8b39d803d148051/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/82a6fca34d153cd12c3829aff8b39d803d148051/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/82a6fca34d153cd12c3829aff8b39d803d148051/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
,
Jul 8 2016
,
Jun 27 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 1 2016