"Advanced" settings section does not animate out |
|||||||||||||
Issue descriptionWhen clicking the "Advanced" settings marker at the bottom of chrome://settings, the "Advanced" section expands instantly, then the scroll position is set to make it visible, which is quite jarring and somewhat disorienting.
,
Jul 6 2016
,
Jul 6 2016
Adding Michael since this may be related to animation and he has more knowledge of smooth scrolling issues.
,
Jul 6 2016
My only knowledge of smooth scrolling is we need a bunch of custom code to do it dynamically. But it's probably worth it for jumping between sections. Animating the expand/collapse is something we can add after https://codereview.chromium.org/2106013002/
,
Jul 22 2016
,
Jul 22 2016
,
Jul 22 2016
,
Sep 7 2016
,
Jan 6 2017
We changed the padding at the bottom of the page so that if you scroll all the way down, you'll see the top of the advanced page when you expand the toggle. We no longer scroll for the user. @bettes, do we want any animation when expanding/collapsing the advanced section?
,
Jan 24 2017
@michael: Would these animations be done with CSS or something else? We can provide you specs for smooth auto-scrolling. I agree, I think this is needed for launch. Please assign back to me. Thanks!
,
Feb 3 2017
routing to Settings people
,
Jul 6 2017
I'm no longer working on Chrome, and unlikely to fix any bug I'm currently assigned. So this bug doesn't languish, I'm unassigning myself.
,
Jun 6 2018
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63 commit e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63 Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Jun 18 23:30:40 2018 Settings: scroll to the advanced settings after expansion Bug: 624849 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I83171f753c73b50e7d674e3f588cd5eb6e3f01d7 Reviewed-on: https://chromium-review.googlesource.com/1089643 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568231} [modify] https://crrev.com/e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/e5d7fdf4d0e68afe341e4cdffedd4469e02a1c63/chrome/test/data/webui/settings/settings_main_test.js
,
Jun 18 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by tbuck...@chromium.org
, Jul 6 2016Labels: Hotlist-MD-Settings-Navigation