ConditionalCacheDeletionHelperBrowserTest.s are flaking on Linux ChromiumOS Tests |
||||||
Issue descriptionConditionalCacheDeletionHelperBrowserTest.TimeAndURL is flaking on Linux ChromiumOS Tests: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29 It's not generating much red, since it usually at least passes on retry. From the log https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/22073/steps/browser_tests%20on%20Ubuntu-12.04/logs/stdio : [ RUN ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL [9887:9887:0630/082549:WARNING:chrome_browser_main_chromeos.cc(333)] Running as stub user with profile dir: test-user [9887:9887:0630/082549:WARNING:audio_manager.cc(297)] Multiple instances of AudioManager detected [9887:9887:0630/082549:WARNING:audio_manager.cc(271)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":9". [9887:9988:0630/082549:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.bv1hp9/dj29fKi/stub_device_local_extension_cache/.initialized exists. [9887:9887:0630/082549:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag. [9887:9947:0630/082549:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. ../../chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc:184: Failure Value of: remaining_keys_ Actual: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://google.com/", "https://google.com/index.html" } Expected: expected Which is: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://example.com/foo/bar/icon.png", "https://google.com/", "https://google.com/index.html" } [ FAILED ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL, where TypeParam = and GetParam() = (523 ms) [34/1300] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL (651 ms) Another failure has been seen with ConditionalCacheDeletionHelperBrowserTest.Condition over in (dbg) log https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/15598/steps/browser_tests%20on%20Ubuntu-12.04/logs/stdio : [0626/103756:ERROR:kill_posix.cc(82)] Unable to terminate process group 31892: No such process [ RUN ] ConditionalCacheDeletionHelperBrowserTest.Condition [31892:31892:0626/103754:WARNING:chrome_browser_main_chromeos.cc(332)] Running as stub user with profile dir: test-user [31892:31892:0626/103754:WARNING:audio_manager.cc(297)] Multiple instances of AudioManager detected [31892:31892:0626/103754:WARNING:audio_manager.cc(271)] Multiple instances of AudioManager detected [31892:31892:0626/103754:ERROR:logging_chrome.cc(172)] Unable to create symlink /tmp/.org.chromium.Chromium.Z71mu6/dNASSdX/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.Z71mu6/dNASSdX/test-user/chrome_debug_20160626-103754.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [31892:31953:0626/103755:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.Z71mu6/dNASSdX/stub_device_local_extension_cache/.initialized exists. [31892:31892:0626/103755:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag. [31892:31956:0626/103755:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [13/607] ConditionalCacheDeletionHelperBrowserTest.Condition (4719 ms) While the warnings look similar, it's not clear that these are actually related errors.
,
Jun 30 2016
Ah, of course. It's this: https://cs.chromium.org/chromium/src/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc?l=245-247 I'll try again to find a way to wait for the event of cache entries being written, but I might end up just incrementing this timeout by a few more milliseconds.
,
Dec 12 2016
Hi - I'm today's Chromium sheriff - the ConditionalCacheDeletionHelperBrowserTest.TimeAndURL test failed today. I'm going to disable the test per our "disable flaky tests" policy. ---- Here's the failing test output from https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1)/builds/30743/steps/browser_tests/logs/ConditionalCacheDeletionHelperBrowserTest.TimeAndURL ConditionalCacheDeletionHelperBrowserTest.TimeAndURL (run #1): [ RUN ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL [8386:8386:1212/133731.976751:WARNING:chrome_browser_main_chromeos.cc(347)] Running as stub user with profile dir: test-user [8386:8386:1212/133732.016386:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [8386:8386:1212/133732.016429:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [8386:8386:1212/133732.019970:WARNING:statistics_provider.cc(285)] Statistics loaded after waiting 0ms. Xlib: extension "RANDR" missing on display ":99". [8386:8489:1212/133732.091396:ERROR:drive_integration_service.cc(120)] /tmp should have been created as clear. [8386:8386:1212/133732.132999:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [8386:8386:1212/133732.133051:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [8386:8386:1212/133732.133099:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [8386:8386:1212/133732.133129:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [8386:8386:1212/133732.133193:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [8386:8478:1212/133732.141284:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [8386:8386:1212/133732.278589:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [8386:8386:1212/133732.278646:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [8386:8386:1212/133732.278685:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [8386:8386:1212/133732.278719:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [8386:8386:1212/133732.278760:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. ../../chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc:184: Failure Value of: remaining_keys_ Actual: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://google.com/", "https://google.com/index.html" } Expected: expected Which is: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://example.com/foo/bar/icon.png", "https://google.com/", "https://google.com/index.html" } [ FAILED ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL, where TypeParam = and GetParam() = (515 ms) ConditionalCacheDeletionHelperBrowserTest.TimeAndURL (run #2): [ RUN ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL [32515:32515:1212/134554.049627:WARNING:chrome_browser_main_chromeos.cc(347)] Running as stub user with profile dir: test-user [32515:32515:1212/134554.073454:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [32515:32515:1212/134554.073479:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":99". [32515:32545:1212/134554.121932:ERROR:drive_integration_service.cc(120)] /tmp should have been created as clear. [32515:32515:1212/134554.149602:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32515:32515:1212/134554.149640:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32515:32515:1212/134554.149668:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32515:32515:1212/134554.149686:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32515:32515:1212/134554.149708:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32515:32536:1212/134554.154271:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [32515:32515:1212/134554.240485:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32515:32515:1212/134554.240531:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32515:32515:1212/134554.240557:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32515:32515:1212/134554.240573:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32515:32515:1212/134554.240596:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. ../../chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc:184: Failure Value of: remaining_keys_ Actual: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://google.com/", "https://google.com/index.html" } Expected: expected Which is: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://example.com/foo/bar/icon.png", "https://google.com/", "https://google.com/index.html" } [ FAILED ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL, where TypeParam = and GetParam() = (338 ms) ConditionalCacheDeletionHelperBrowserTest.TimeAndURL (run #3): [ RUN ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL [32758:32758:1212/134557.008252:WARNING:chrome_browser_main_chromeos.cc(347)] Running as stub user with profile dir: test-user [32758:32758:1212/134557.033024:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [32758:32758:1212/134557.033048:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":99". [32758:323:1212/134557.091879:ERROR:drive_integration_service.cc(120)] /tmp should have been created as clear. [32758:32758:1212/134557.123939:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32758:32758:1212/134557.123977:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32758:32758:1212/134557.124005:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32758:32758:1212/134557.124022:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32758:32758:1212/134557.124045:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32758:313:1212/134557.128459:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [32758:32758:1212/134557.240157:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32758:32758:1212/134557.240192:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32758:32758:1212/134557.240216:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [32758:32758:1212/134557.240233:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [32758:32758:1212/134557.240254:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. ../../chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc:184: Failure Value of: remaining_keys_ Actual: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://google.com/", "https://google.com/index.html" } Expected: expected Which is: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://example.com/foo/bar/icon.png", "https://google.com/", "https://google.com/index.html" } [ FAILED ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL, where TypeParam = and GetParam() = (400 ms) ConditionalCacheDeletionHelperBrowserTest.TimeAndURL (run #4): [ RUN ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL [373:373:1212/134557.544783:WARNING:chrome_browser_main_chromeos.cc(347)] Running as stub user with profile dir: test-user [373:373:1212/134557.571923:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [373:373:1212/134557.571952:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":99". [373:405:1212/134557.625204:ERROR:drive_integration_service.cc(120)] /tmp should have been created as clear. [373:373:1212/134557.654631:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [373:373:1212/134557.654673:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [373:373:1212/134557.654701:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [373:373:1212/134557.654718:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [373:373:1212/134557.654740:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [373:394:1212/134557.659845:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [373:373:1212/134557.744164:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : ahfgeienlihckogmohjhadlkjgocpleb / Web Store because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [373:373:1212/134557.744223:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : eemcgdkfndhakfknompkggombfjjjeno / Bookmark Manager because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [373:373:1212/134557.744258:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mgndgikekgjfcpckkfioiadnlibdjbkf / Chromium because of 'signin_screen' is only allowed for packaged apps, but this is a hosted app. [373:373:1212/134557.744288:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : mhjfbmdgcfjbbpaeojofohoefgiehjai / Chromium PDF Viewer because of 'signin_screen' is only allowed for packaged apps, but this is a extension. [373:373:1212/134557.744320:WARNING:signin_screen_policy_provider.cc(61)] Denying load of Extension : nkoccljplnhpfnfiajclkommnmllphnl / crosh_builtin because of 'signin_screen' is only allowed for packaged apps, but this is a extension. ../../chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc:184: Failure Value of: remaining_keys_ Actual: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://google.com/", "https://google.com/index.html" } Expected: expected Which is: { "http://chrome.com", "http://example.com/foo/bar/icon4.png", "https://example.com/foo/bar/icon.png", "https://google.com/", "https://google.com/index.html" } [ FAILED ] ConditionalCacheDeletionHelperBrowserTest.TimeAndURL, where TypeParam = and GetParam() = (393 ms)
,
Dec 12 2016
You can see all the flakes here as well: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ConditionalCacheDeletionHelperBrowserTest.TimeAndURL&testType=browser_tests Looks like it pretty frequently fails but then passes on retry within a given test cycle.
,
Dec 13 2016
Acknowledged, thanks. Browser tests for cache are hard - it returns completion callbacks before the data is actually written. :-( I'm not aware of a better solution than increasing the time limits. Maybe we should just drop the browsertest and use a unittest instead.
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/389790ddbe136ef1704b3503dfd323670983add8 commit 389790ddbe136ef1704b3503dfd323670983add8 Author: asargent <asargent@chromium.org> Date: Tue Dec 13 10:06:40 2016 Disable ConditionalCacheDeletionHelperBrowserTest.TimeAndURL on linux The test has been flaky on Linux/ChromeOS. TBR=msramek@chromium.org BUG= 624836 Review-Url: https://codereview.chromium.org/2569083002 Cr-Commit-Position: refs/heads/master@{#438113} [modify] https://crrev.com/389790ddbe136ef1704b3503dfd323670983add8/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
,
Apr 3 2017
This test is flaking on the Site Isolation Android bot as well. Instead of using the test specific time to sleep, why not use TestTimeouts::tiny_timeout() from base? It is meant to be globally adjustable value and likely one that works for most tests.
,
Apr 4 2017
Sounds reasonable, thanks! +dullweber@ you said you'd have a look :)
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f48da6f6814d77b35c3d91a4df5dca714e01af0d commit f48da6f6814d77b35c3d91a4df5dca714e01af0d Author: dullweber <dullweber@chromium.org> Date: Wed Apr 05 09:09:11 2017 Enable ConditionalCacheDeletionHelperBrowserTest.TimeAndURL again Change ConditionalCacheDeletionHelperBrowserTest.TimeAndURL to use TestTimeouts::tiny_timeout instead of a smaller custom timeout and enable it again on platforms that were previously flaky. BUG= 624836 , 646119 Review-Url: https://codereview.chromium.org/2795233002 Cr-Commit-Position: refs/heads/master@{#462014} [modify] https://crrev.com/f48da6f6814d77b35c3d91a4df5dca714e01af0d/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
,
Apr 26 2017
The tests seem to work fine now.
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msramek@chromium.org
, Jun 30 2016