HDMI node is shown as plugged after 10 seconds delay |
|||||||||||||||||||
Issue descriptionhttps://wmatrix.googleplex.com/platform/unfiltered?hide_missing=True&tests=audio_AudioBasicHDMI&days_back=20&platforms=nyan_big It shows that the failure rate is getting very high starting from 8508.0. I am trying to figure out if there is some regression. This CL https://chromium-review.googlesource.com/#/c/355772/3 might be related but I am not sure. I am currently blocking by https://bugs.chromium.org/p/chromium/issues/detail?id=624816 to do the testing.
,
Jul 1 2016
It is hard to tell what is wrong. 1. The test fails on R53, but pass on R52, with the same setup android1758-audiobox1-host1. This suggests that some CL broke it. 2. In one of my testing running the test from my workstation against android1758-audiobox1-host1, audio_diagnostic result shows HDMI node is selected. However, chrome.audio API returns that SPEAKER node is selected. 3. After the first testing, I can not reproduce this issue anymore. 4. In failure log of 8508, 8516, 8523, 8524, 8526, 8529, HDMI jack is "on", but CRAS does not see it is plugged. This means that jack_state_change_cb failed to report jack status. numid=1,iface=CARD,name='HDMI/DP,pcm=3 Jack' ; type=BOOLEAN,access=r-------,values=1 : values=on 5. The interesting coincident is that CL https://chromium-review.googlesource.com/#/c/355772/3 is changing the retry time of jack_state_change_cb from 10 to 25. Since it is hard to debug right now as I can not reproduce it anymore, we can wait for R52-8350.48 image get the test result, since the CL was cherry-picked to R52 too https://chromium-review.googlesource.com/#/c/356861/. If R52-8350.48.0 also fails, then we know it must be that CL causing the failure.
,
Jul 1 2016
I just run 20/20 passed on 8526 on android1758-audiobox1-host1. It is hard to debug further. Let's wait for R52 result.
,
Jul 1 2016
,
Jul 4 2016
I found the root cause. It is indeed related to CL https://chromium-review.googlesource.com/#/c/355772/3 The retry limit is increased from 10 to 25, with each retry adding 200ms delay. On nyan_big, the ELD control information is never valid. Thus, it adds 2.5 * 200ms = 5s for CRAS to change the jack status to be plugged. We should actually report jack status to be plugged right away. Then, use another timer to poll display name, and update it when it is ready. This is different from gpio jack using EDID because EDID may tell CRAS that this display does not support audio. If a hctl jack is reported as value "on", it means that display supports audio. Hi Dylan, do you think this approach looks good ? If so I can make the change to cras_alsa_jack to separate EDID and ELD paths. Thanks!
,
Jul 4 2016
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e8a04ef732f97405d91783ddfd3d64ca50ca16b1 commit e8a04ef732f97405d91783ddfd3d64ca50ca16b1 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Mon Jul 04 09:44:02 2016 CRAS: alsa_jack: report jack status right away for hctl jack hctl jack does not need to check EDID file to make sure it supports audio or not. Jack status should be reported to alsa_io right away. The display info in ELD control can be updated later. BUG= chromium:624819 TEST=on nyan_big, check HDMI is shown as plugged few seconds after plugging HDMI cable rather than 10 seconds. Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> Change-Id: Ib2e09b2556b7f95da8f31c99714b5039e7ec8fb7 Reviewed-on: https://chromium-review.googlesource.com/358281 [modify] https://crrev.com/e8a04ef732f97405d91783ddfd3d64ca50ca16b1/cras/src/server/cras_alsa_jack.c [modify] https://crrev.com/e8a04ef732f97405d91783ddfd3d64ca50ca16b1/cras/src/tests/alsa_jack_unittest.cc
,
Jul 12 2016
https://wmatrix.googleplex.com/platform/unfiltered?platforms=nyan_big&suites=chameleon_audio_perbuild&days_back=20&releases=53&hide_missing=True CL in #7 needs to be merged to R53 to solve the test failures. Thanks!
,
Jul 12 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/10312fcb1e8c4d9bb3f7b46d3b08c3a32ca6a878 commit 10312fcb1e8c4d9bb3f7b46d3b08c3a32ca6a878 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Mon Jul 04 09:44:02 2016 CRAS: alsa_jack: report jack status right away for hctl jack hctl jack does not need to check EDID file to make sure it supports audio or not. Jack status should be reported to alsa_io right away. The display info in ELD control can be updated later. BUG= chromium:624819 TEST=on nyan_big, check HDMI is shown as plugged few seconds after plugging HDMI cable rather than 10 seconds. Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> Change-Id: Ib2e09b2556b7f95da8f31c99714b5039e7ec8fb7 Previous-Reviewed-on: https://chromium-review.googlesource.com/358281 (cherry picked from commit de6174203680bc882fecc00c54ecb382c14a0b75) Reviewed-on: https://chromium-review.googlesource.com/360060 [modify] https://crrev.com/10312fcb1e8c4d9bb3f7b46d3b08c3a32ca6a878/cras/src/server/cras_alsa_jack.c [modify] https://crrev.com/10312fcb1e8c4d9bb3f7b46d3b08c3a32ca6a878/cras/src/tests/alsa_jack_unittest.cc
,
Jul 15 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 18 2016
,
Jul 18 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 23 2016
,
Oct 5 2016
CL https://chromium-review.googlesource.com/#/c/358281/ is going to be revert due to issue 651594 cychiang@ and I have discussed another fix for this issue that won't affect issue 651594 .
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/a8f9776c84fffc77b9e277478cffaa3ca1947ccc commit a8f9776c84fffc77b9e277478cffaa3ca1947ccc Author: Chinyue Chen <chinyue@chromium.org> Date: Thu Oct 06 08:17:47 2016 CRAS: alsa_jack - Use different timeout for different type of jacks. GPIO jack on some boards need long timeout for working correctly. However that affects HCTL jacks on some boards to wait too long. Use different timeout for each of them so both work happily. BUG= chromium:624819 TEST=Verified on big that HDMI node got selected soon after plugged in. Change-Id: Iebb7be897ed931d943233cf163bb61933b81eeb3 Reviewed-on: https://chromium-review.googlesource.com/394468 Commit-Ready: Chinyue Chen <chinyue@chromium.org> Tested-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/a8f9776c84fffc77b9e277478cffaa3ca1947ccc/cras/src/server/cras_alsa_jack.c
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/a8f9776c84fffc77b9e277478cffaa3ca1947ccc commit a8f9776c84fffc77b9e277478cffaa3ca1947ccc Author: Chinyue Chen <chinyue@chromium.org> Date: Thu Oct 06 08:17:47 2016 CRAS: alsa_jack - Use different timeout for different type of jacks. GPIO jack on some boards need long timeout for working correctly. However that affects HCTL jacks on some boards to wait too long. Use different timeout for each of them so both work happily. BUG= chromium:624819 TEST=Verified on big that HDMI node got selected soon after plugged in. Change-Id: Iebb7be897ed931d943233cf163bb61933b81eeb3 Reviewed-on: https://chromium-review.googlesource.com/394468 Commit-Ready: Chinyue Chen <chinyue@chromium.org> Tested-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/a8f9776c84fffc77b9e277478cffaa3ca1947ccc/cras/src/server/cras_alsa_jack.c
,
Oct 13 2016
The re-fix CL https://chromium-review.googlesource.com/394468 needs to be merged to M54 and M55, where the original fix was reverted.
,
Oct 13 2016
,
Oct 13 2016
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
,
Oct 13 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 30 2016
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 1 2016
,
Dec 16 2016
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/c9e53a0e8ef3cc1b133126470fdbfe7c193f1cb2 commit c9e53a0e8ef3cc1b133126470fdbfe7c193f1cb2 Author: Chinyue Chen <chinyue@chromium.org> Date: Thu Oct 06 08:17:47 2016 CRAS: alsa_jack - Use different timeout for different type of jacks. GPIO jack on some boards need long timeout for working correctly. However that affects HCTL jacks on some boards to wait too long. Use different timeout for each of them so both work happily. BUG= chromium:624819 TEST=Verified on big that HDMI node got selected soon after plugged in. Change-Id: Iebb7be897ed931d943233cf163bb61933b81eeb3 Reviewed-on: https://chromium-review.googlesource.com/394468 Commit-Ready: Chinyue Chen <chinyue@chromium.org> Tested-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> (cherry picked from commit a8f9776c84fffc77b9e277478cffaa3ca1947ccc) Reviewed-on: https://chromium-review.googlesource.com/421069 Reviewed-by: Chinyue Chen <chinyue@chromium.org> Commit-Queue: Chinyue Chen <chinyue@chromium.org> [modify] https://crrev.com/c9e53a0e8ef3cc1b133126470fdbfe7c193f1cb2/cras/src/server/cras_alsa_jack.c
,
Dec 16 2016
,
Dec 19 2016
Verified on build 8872.73.0 |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by cychiang@chromium.org
, Jun 30 2016