Plumbing stylus tilt for Mac |
|||||||
Issue descriptionPlumbing the stylus properties of tilt, pressure and rotation for Mac through the properties of TabletProximity events.
,
Sep 13 2016
Looks like part of the plumbing has been done! https://twitter.com/patrick_h_lauke/status/774954950845722626 Tilt is still missing.
,
Sep 13 2016
For records: Lan's CL for Mac PointerType included pointerId & pressure. I missed adding this bug to that CL description, sorry. https://codereview.chromium.org/2022843002
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bf47bb4e1d0ea9599bc443906fc26c3ce86f152 commit 8bf47bb4e1d0ea9599bc443906fc26c3ce86f152 Author: robhogan <robhogan@gmail.com> Date: Thu Sep 15 11:49:49 2016 Don't repeat headers if at least one row of content doesn't fit The spec (https://drafts.csswg.org/css-tables-3/#repeated-headers) tells us that we shouldn't bother repeating headers if a row of content doesn't fit. It's not clear what to do in the situation where it's just the first page that the row doesn't fit. I think we ultimately want to do the same as Edge/IE and still repeat the headers on subsequent pages. That would require a second layout pass to achieve so for now just drop the repeating headers if we can't fit a row on the first page. BUG= 624814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2326303002 Cr-Commit-Position: refs/heads/master@{#418838} [add] https://crrev.com/8bf47bb4e1d0ea9599bc443906fc26c3ce86f152/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page-break-after-avoid-expected.html [add] https://crrev.com/8bf47bb4e1d0ea9599bc443906fc26c3ce86f152/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page-break-after-avoid.html [modify] https://crrev.com/8bf47bb4e1d0ea9599bc443906fc26c3ce86f152/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/8bf47bb4e1d0ea9599bc443906fc26c3ce86f152/third_party/WebKit/Source/core/layout/LayoutTableSection.h [modify] https://crrev.com/8bf47bb4e1d0ea9599bc443906fc26c3ce86f152/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
,
Sep 15 2016
+robhogan, looks like you used the wrong bug number?
,
Sep 20 2016
,
Sep 20 2016
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c6775ddd60897fd815139b9afe9198c4263dae3 commit 3c6775ddd60897fd815139b9afe9198c4263dae3 Author: lanwei <lanwei@chromium.org> Date: Tue Sep 20 17:23:36 2016 Plumbing stylus tilt for Mac. Add the stylus tilt information for pointer event on Mac. Mac's NSEvent's tilt has a range from -1.0 to 1.0 for both axes, but our values lie in [-90,90]. https://developer.apple.com/reference/appkit/nsevent/1534226-tilt BUG= 624814 Review-Url: https://codereview.chromium.org/2349143004 Cr-Commit-Position: refs/heads/master@{#419801} [modify] https://crrev.com/3c6775ddd60897fd815139b9afe9198c4263dae3/content/browser/renderer_host/input/web_input_event_builders_mac.mm
,
Sep 20 2016
,
Oct 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee7ca0fdc96ab4ba61d0be876c8e779adced302d commit ee7ca0fdc96ab4ba61d0be876c8e779adced302d Author: Robert Hogan <robhogan@gmail.com> Date: Sat Oct 08 11:56:00 2016 Don't repeat headers if at least one row of content doesn't fit The spec (https://drafts.csswg.org/css-tables-3/#repeated-headers) tells us that we shouldn't bother repeating headers if a row of content doesn't fit. It's not clear what to do in the situation where it's just the first page that the row doesn't fit. I think we ultimately want to do the same as Edge/IE and still repeat the headers on subsequent pages. That would require a second layout pass to achieve so for now just drop the repeating headers if we can't fit a row on the first page. BUG= 624814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2326303002 Cr-Commit-Position: refs/heads/master@{#418838} (cherry picked from commit 8bf47bb4e1d0ea9599bc443906fc26c3ce86f152) Review URL: https://codereview.chromium.org/2400303004 . Cr-Commit-Position: refs/branch-heads/2840@{#694} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page-break-after-avoid-expected.html [add] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page-break-after-avoid.html [modify] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/Source/core/layout/LayoutTableSection.h [modify] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
,
Oct 11 2016
Rob Hogan, looks like you used the wrong bug number?
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee7ca0fdc96ab4ba61d0be876c8e779adced302d commit ee7ca0fdc96ab4ba61d0be876c8e779adced302d Author: Robert Hogan <robhogan@gmail.com> Date: Sat Oct 08 11:56:00 2016 Don't repeat headers if at least one row of content doesn't fit The spec (https://drafts.csswg.org/css-tables-3/#repeated-headers) tells us that we shouldn't bother repeating headers if a row of content doesn't fit. It's not clear what to do in the situation where it's just the first page that the row doesn't fit. I think we ultimately want to do the same as Edge/IE and still repeat the headers on subsequent pages. That would require a second layout pass to achieve so for now just drop the repeating headers if we can't fit a row on the first page. BUG= 624814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2326303002 Cr-Commit-Position: refs/heads/master@{#418838} (cherry picked from commit 8bf47bb4e1d0ea9599bc443906fc26c3ce86f152) Review URL: https://codereview.chromium.org/2400303004 . Cr-Commit-Position: refs/branch-heads/2840@{#694} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page-break-after-avoid-expected.html [add] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-starts-middle-of-page-break-after-avoid.html [modify] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/Source/core/layout/LayoutTableSection.h [modify] https://crrev.com/ee7ca0fdc96ab4ba61d0be876c8e779adced302d/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mustaq@chromium.org
, Jun 30 2016