Issue metadata
Sign in to add a comment
|
Enable SSL on some search engines
Reported by
resea...@nightwatchcybersecurity.com,
Jun 30 2016
|
||||||||||||||||||||||||
Issue descriptionThis is a partial patch for this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=597972 This patch enables SSL for some search engines that now support it.
,
Jul 1 2016
,
Jul 1 2016
Unduping. This isn't the same as "remove all non-HTTPS engines".
,
Jul 1 2016
Please do post the patch in comment 0 for review. You can set me as a reviewer. Make sure to rev the prepopulate data version number. Note that things like the favicon URL should match whatever the site actually uses as its favicon URL, or they won't get properly populated in the search engine management dialog. Though my hope is that any engine using a secure search URL is using a secure favicon URL...
,
Jul 3 2016
We uploaded a patch for review here: https://codereview.chromium.org/2116243002/ Let us know if this worked. Thanks.
,
Feb 11 2017
This bug and CL seem relevant to some more folks
,
Mar 9 2017
,
Mar 17 2017
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e67d600e764d643cc215c38f465ecf6b89e9406 commit 6e67d600e764d643cc215c38f465ecf6b89e9406 Author: yakov <yakov@impossibledreams.net> Date: Tue Mar 21 03:41:25 2017 Enabling SSL for search engines that now support it BUG= 624794 R=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2753293002 Cr-Commit-Position: refs/heads/master@{#458299} [modify] https://crrev.com/6e67d600e764d643cc215c38f465ecf6b89e9406/AUTHORS [modify] https://crrev.com/6e67d600e764d643cc215c38f465ecf6b89e9406/components/search_engines/prepopulated_engines.json
,
Mar 21 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by palmer@chromium.org
, Jun 30 2016Status: Duplicate (was: Unconfirmed)