New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624794 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 597972
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Enable SSL on some search engines

Reported by resea...@nightwatchcybersecurity.com, Jun 30 2016

Issue description

This is a partial patch for this bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=597972

This patch enables SSL for some search engines that now support it.
 
ssl.patch
5.7 KB Download

Comment 1 by palmer@chromium.org, Jun 30 2016

Mergedinto: 597972
Status: Duplicate (was: Unconfirmed)
Thanks! To contribute code to Chromium, please follow this guide: https://www.chromium.org/developers/contributing-code

Comment 2 by wfh@chromium.org, Jul 1 2016

Labels: -Restrict-View-SecurityTeam
Components: UI>Browser>Search
Labels: -Type-Bug-Security OS-All Pri-2 Type-Feature
Status: Available (was: Duplicate)
Summary: Enable SSL on some search engines (was: Security: Patch for enabling SSL on some search engines)
Unduping.  This isn't the same as "remove all non-HTTPS engines".
Please do post the patch in comment 0 for review.  You can set me as a reviewer.  Make sure to rev the prepopulate data version number.

Note that things like the favicon URL should match whatever the site actually uses as its favicon URL, or they won't get properly populated in the search engine management dialog.

Though my hope is that any engine using a secure search URL is using a secure favicon URL...
We uploaded a patch for review here:
https://codereview.chromium.org/2116243002/

Let us know if this worked. Thanks.
Cc: palmer@chromium.org lgar...@chromium.org emilyschechter@chromium.org
This bug and CL seem relevant to some more folks
Cc: ya...@nightwatchcybersecurity.com

Comment 8 Deleted

Comment 9 Deleted

Status: Fixed (was: Available)

Sign in to add a comment