Regression : Drop down of sign in page overlay is seen even on clicking outside of the overlay |
|||
Issue descriptionVersion: 52.0.2743.60 OS: Ubuntu 14.04, Windows Precondition: Enable 'new gaia password-separated sign in flow' flag from 'chrome://flags' What steps will reproduce the problem? (1)Launch chrome ->click on avatar icon in top right corner (2)Now click on 'Sign in to chrome' button -> Now click on 'More options' drop down list (3)Now click on outside of the sign in page overlay and observe (Please refer Video) Expected: Drop down should get closed on clicking outside of the sign in page overlay Actual: Instead Drop down is seen This is Regression Issue broken in M-49 Manual good and Bad Builds: Good Build: 49.0.2579.0 Bad Build: 49.0.2581.0 Below is the Bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e4cc968655ef536c9e6002cd0baf59adcf3ad137..70f3fac9eba163c6b59ca23e88f720a035312394 Suspecting https://codereview.chromium.org/1413533009 from above changelog @anthonyvd : Please feel free to re-assign if its not related to your change
,
Jun 30 2016
Reproducible on the latest canary(53.0.2784.1) on Mac OS 10.11.5 as well.
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 6 2016
Thanks for the report. For context: that "expected" video is a bit misleading as the menu probably doesn't close there either before the entire window does. There was never any intention of having that sign in flow in that bubble either, this build just didn't have the full changes landed. As for the bug you describe, I think it's WAI. Since the sign in flow is modal, clicking anywhere outside of it shouldn't perform any action. Because of this, leaving the menu open allows the user to resume what they were doing more easily if they try to click outside. Finally, changing this would mean adding logic to the modal dialog system that allows propagating click events to the web contents of the flow. This is way too intrusive and complex to be worth it for such a small issue. It also makes little sense from a browser perspective. The dialog is displaying web contents and the web platform has no concept of events happening outside the page's content. |
|||
►
Sign in to add a comment |
|||
Comment 1 by brajkumar@chromium.org
, Jun 30 2016