New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624764 link

Starred by 2 users
Status: Fixed
Owner:
cmumford@chromium.org
Closed: Jul 2016
Cc:
hablich@chromium.org
adamk@chromium.org
█ epertoso@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.1%-11.4% regression in speedometer at 402557:402634

Project Member Reported by epertoso@chromium.org, Jun 30 2016

Comment 1 by epertoso@chromium.org, Jun 30 2016 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=624764

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4qSluwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4uSJsAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4t6IsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4oaYpgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4qK6qQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4rH1oAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4sbAqQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkuDxvwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4reSowoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4oatoQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4p7DvgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4pS0tAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkuCWrgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkuCWrgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4p7ZrwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4qLssAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4rfEvAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4obmrgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgksTSswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgotfltwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgotfltwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4oDTrQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4onauwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4p6ypwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg4u7_qwoM


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
chromium-rel-mac10
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release

Comment 2 by epertoso@chromium.org, Jun 30 2016

Cc: epertoso@chromium.org hablich@chromium.org
Owner: adamk@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b324850900e531ccee03f1712333f13dfcf15427

commit b324850900e531ccee03f1712333f13dfcf15427
Author: adamk <adamk@chromium.org>
Date: Thu Jun 30 16:55:47 2016

Revert of Add crash instrumentation for crbug.com/621147 (patchset #5 id:80001 of https://codereview.chromium.org/2100313002/ )

Reason for revert:
Instrumentation not needed on master branch

Original issue's description:
> Add crash instrumentation for crbug.com/621147
>
> BUG=chromium:621147
> LOG=N
> R=ishell@chromium.org,cbruni@chromium.org
>
> Committed: https://crrev.com/5ff508a82299f20a0d9828cf73072a4f4772fab8
> Cr-Commit-Position: refs/heads/master@{#37328}

TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:621147,  chromium:624764 

Review-Url: https://codereview.chromium.org/2118493002
Cr-Commit-Position: refs/heads/master@{#37456}

[modify] https://crrev.com/b324850900e531ccee03f1712333f13dfcf15427/src/ic/ic.cc

Comment 4 by adamk@chromium.org, Jun 30 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6e9832583c23f10fb2e66b6bfeacc4605ef0c082

commit 6e9832583c23f10fb2e66b6bfeacc4605ef0c082
Author: adamk <adamk@chromium.org>
Date: Thu Jun 30 17:51:12 2016

Reland of Add crash instrumentation for crbug.com/621147 (patchset #1 id:1 of https://codereview.chromium.org/2118493002/ )

Reason for revert:
By request from ishell, plan is to leave this in master for awhile longer

Original issue's description:
> Revert of Add crash instrumentation for crbug.com/621147 (patchset #5 id:80001 of https://codereview.chromium.org/2100313002/ )
>
> Reason for revert:
> Instrumentation not needed on master branch
>
> Original issue's description:
> > Add crash instrumentation for crbug.com/621147
> >
> > BUG=chromium:621147
> > LOG=N
> > R=ishell@chromium.org,cbruni@chromium.org
> >
> > Committed: https://crrev.com/5ff508a82299f20a0d9828cf73072a4f4772fab8
> > Cr-Commit-Position: refs/heads/master@{#37328}
>
> TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=chromium:621147,  chromium:624764 
>
> Committed: https://crrev.com/b324850900e531ccee03f1712333f13dfcf15427
> Cr-Commit-Position: refs/heads/master@{#37456}

TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:621147,  chromium:624764 

Review-Url: https://codereview.chromium.org/2114743002
Cr-Commit-Position: refs/heads/master@{#37458}

[modify] https://crrev.com/6e9832583c23f10fb2e66b6bfeacc4605ef0c082/src/ic/ic.cc

Comment 6 by adamk@chromium.org, Jun 30 2016

Labels: -M-53 M-54 ReleaseBlock-Beta
Status: Assigned (was: Fixed)
The instrumentation has been removed from the M53 branch, but we're leaving it on in master for awhile longer. Marking as ReleaseBlock-Beta for M54 to make sure we don't forget to turn it off again.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 30 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Adds a crash key to V8EventListener to help diagnose crbug.com/621730 .
Author  : Yuki Shiino
Commit description:
  
This change can be reverted after a day or two of data.

BUG=621730
R=haraken@chromium.org, rsesek@chromium.org

Review URL: https://codereview.chromium.org/2107773002 .

Cr-Commit-Position: refs/heads/master@{#402609}
Commit  : d0210f38391ce7282cab3279a1ddcbff6a975d64
Date    : Wed Jun 29 00:14:04 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@402607  952.067  65.4167  93  good
chromium@402608  946.483  48.0675  93  good
chromium@402609  958.886  39.307   62  bad    <--
chromium@402610  960.037  54.2441  93  bad
chromium@402612  956.783  52.7538  93  bad
chromium@402616  989.689  66.805   8   bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 624764

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: React-TodoMVC/React-TodoMVC
Relative Change: 9.44%
Score: 0.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2174
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008430484770790464


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4884844752928768

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a182588d49ee9084ed4dcee799e59cea3473fa32

commit a182588d49ee9084ed4dcee799e59cea3473fa32
Author: jkummerow <jkummerow@chromium.org>
Date: Wed Jul 06 13:28:39 2016

Revert of Add crash instrumentation for crbug.com/621147 (patchset #1 id:1 of https://codereview.chromium.org/2114743002/ )

Reason for revert:
Bug found and fixed: crrev.com/7614362b7e619f9c6c1d2681c6de02b966782d0e

Instrumentation no longer needed.

Original issue's description:
> Add crash instrumentation for crbug.com/621147
>
> BUG=chromium:621147
> LOG=N
> R=ishell@chromium.org,cbruni@chromium.org
>
> Committed: https://crrev.com/5ff508a82299f20a0d9828cf73072a4f4772fab8
> Cr-Commit-Position: refs/heads/master@{#37328}

TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org,adamk@chromium.org
BUG=chromium:621147,  chromium:624764 

Review-Url: https://codereview.chromium.org/2127813002
Cr-Commit-Position: refs/heads/master@{#37552}

[modify] https://crrev.com/a182588d49ee9084ed4dcee799e59cea3473fa32/src/ic/ic.cc

Comment 9 by tdres...@chromium.org, Jul 12 2016 

This hasn't caused full recovery on a few bots:
ChromiumPerf/win-zenbook/indexeddb_perf / Total Perf
ChromiumPerf/android-galaxy-s5/indexeddb_perf / Total Perf

for instance.

Comment 10 by adamk@chromium.org, Jul 14 2016

Cc: adamk@chromium.org
Components: Blink>Bindings
Owner: yukishiino@chromium.org
Per the bisect, it looks like this is due to a Blink change, reassigning.

Comment 11 by yukishiino@chromium.org, Jul 19 2016

Owner: cmumford@chromium.org
Seems mostly okay, but just in case, forwarding to the owner of indexeddb_perf.

Comment 12 by cmumford@chromium.org, Jul 19 2016

Status: Fixed (was: Assigned)
All tests have recovered with the exception of the win7/dual - but that one historically is bimodal. Marking as fixed.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 30 2016

Labels: merge-merged-5.2
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/018bc9f67a928f86def664d35d92c84d6948401e

commit 018bc9f67a928f86def664d35d92c84d6948401e
Author: Camillo Bruni <cbruni@chromium.org>
Date: Tue Aug 30 19:02:24 2016

Merged: Revert of Add crash instrumentation for crbug.com/621147 (patchset #5 id:80001 of https://codereview.chromium.org/2100313002/ )

Reason for revert:
Instrumentation not needed on master branch

Revision: b324850900e531ccee03f1712333f13dfcf15427

BUG=chromium:621147, chromium:624764 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=adamk@chromium.org

Review URL: https://codereview.chromium.org/2290333003 .

Cr-Commit-Position: refs/branch-heads/5.2@{#70}
Cr-Branched-From: 2cd36d6d0439ddfbe84cd90e112dced85084ec95-refs/heads/5.2.361@{#1}
Cr-Branched-From: 3fef34e02388e07d46067c516320f1ff12304c8e-refs/heads/master@{#36332}

[modify] https://crrev.com/018bc9f67a928f86def664d35d92c84d6948401e/src/ic/ic.cc
►

Sign in to add a comment