New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624722 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Jul 2016
Cc:
nyerramilli@chromium.org
dbeam@chromium.org
tbuck...@chromium.org
█ tkonch...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [MD Settings]Weird behavior of mouse pointer is observed on 'Password and forms' section.

Reported by dchau...@etouch.net, Jun 30 2016 
Chrome Version: 53.0.2784.0 (Official Build)642ae4ba1dc7b04a1d480d733cdced28de720e00-refs/heads/master@{#403038} 32/64-bit.
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings and click on 'Advanced' button.
2. Go to 'Password and forms' section and click on autofill toggle button such that it gets disabled.
3. Now, hover the mouse pointer on 'Autofill settings' text and observe.

Unnecessary hand pointer is seen on hovering the mouse pointer.
Arrow pointer should be seen on hovering the mouse pointer.

This is a regression issue, broken in M-53 series, below is bisect info.

Good build: 53.0.2776.0
Bad build: 53.0.2778.0

Narrow bisect;
https://chromium.googlesource.com/chromium/src/+log/ec749b1eeaa49a45973e651e870ed16531c8b0d9..1fa2a1476f5bb37a192979135e5a7a4c7595dbcb?pretty=fuller&n=100

Suspecting: r401763

Kindly review the attached screen-cast for reference.
Actual screenhot.png
102 KB View Download
Actual behavior.mp4
1.3 MB View Download

Comment 1 by dbeam@chromium.org, Jun 30 2016

Cc: tbuck...@chromium.org dbeam@chromium.org
Owner: hcarmona@chromium.org
hcarmona@: can you make the labels conditionally [actionable], as in: only show a hand cursor when a tap/click would have an effect?

I just searched for all tags with an on-tap in their template and without a default cursor: pointer; style.  It seems like this row has an on-tap that doesn't always do something, so we should make sure only to apply cursor: pointer; when clicking/tapping *WOULD* do something.

Comment 2 by dbeam@chromium.org, Jun 30 2016

Labels: -M-53

Comment 3 by mgreenwald@google.com, Jul 7 2016

Labels: Hotlist-MD-Settings-PasswordsForms
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/710345ad1b827d9362f0b274005d928f46c4d1a0

commit 710345ad1b827d9362f0b274005d928f46c4d1a0
Author: hcarmona <hcarmona@chromium.org>
Date: Fri Jul 15 23:34:54 2016

[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG= 624722 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111643005
Cr-Commit-Position: refs/heads/master@{#405897}

[modify] https://crrev.com/710345ad1b827d9362f0b274005d928f46c4d1a0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/710345ad1b827d9362f0b274005d928f46c4d1a0/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js

Comment 5 by hcarmona@chromium.org, Jul 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment