New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624711 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Leaves the project on 2018/03/02
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Give better name for TestRunner's setAlwaysAcceptCookies() method

Project Member Reported by tyoshino@chromium.org, Jun 30 2016

Issue description

This method turns on/off third-party cookie blocking. Should be renamed to more descriptive name.
 
Shall we align it with WebTestDelegate::SetAcceptAllCookies()? This naming is used for all variables and methods beyond it.

Or should we mention third_party cookies?

e.g. flip the bool and name it SetBlockThirdPartyCookies().
Components: Blink>Infra
Owner: tyoshino@chromium.org
Status: Started (was: Available)
https://codereview.chromium.org/2125523003/
Components: Privacy
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6b914673aa766600e9a6b76cad34563941d0e97

commit a6b914673aa766600e9a6b76cad34563941d0e97
Author: tyoshino <tyoshino@chromium.org>
Date: Mon Jul 11 09:15:09 2016

Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG= 624711 
R=mkwst,rdsmith,clamy

Review-Url: https://codereview.chromium.org/2125523003
Cr-Commit-Position: refs/heads/master@{#404620}

[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/components/test_runner/test_runner.cc
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/components/test_runner/test_runner.h
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/components/test_runner/web_test_delegate.h
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/browser/loader/resource_dispatcher_host_browsertest.cc
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/browser/layout_test/layout_test_message_filter.cc
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/browser/layout_test/layout_test_message_filter.h
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/browser/shell_network_delegate.cc
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/browser/shell_network_delegate.h
[add] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/common/layout_test/OWNERS
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/cookies/resources/resetCookies.js
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/cookies/resources/testharness-helpers.js
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/fetch/resources/init.js
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/first-party-cookie-allow.xsl
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/security/cookies/resources/third-party-cookie-blocking.xsl
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-cookies.html
[modify] https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb116be5c0899dc76e114b04d0954248a1380d2

commit bfb116be5c0899dc76e114b04d0954248a1380d2
Author: horo <horo@chromium.org>
Date: Thu May 11 23:17:12 2017

s/setAlwaysAcceptCookies/setBlockThirdPartyCookies/ in third-party-cookie-relaxing-iframe.html

This method name was renamed by https://codereview.chromium.org/2125523003.

BUG= 624711 

Review-Url: https://codereview.chromium.org/2878663002
Cr-Commit-Position: refs/heads/master@{#471115}

[modify] https://crrev.com/bfb116be5c0899dc76e114b04d0954248a1380d2/third_party/WebKit/LayoutTests/http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html

Sign in to add a comment