New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624709 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Build failure: some force-gpu-rasterization tests changed color

Project Member Reported by horo@chromium.org, Jun 30 2016

Issue description

Comment 1 by horo@chromium.org, Jun 30 2016

Owner: noel@chromium.org
Status: Assigned (was: Available)
noel@
Could you please take a look?
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99b64d7535aaf9945e2031d71d59e29f8cbb799c

commit 99b64d7535aaf9945e2031d71d59e29f8cbb799c
Author: horo <horo@chromium.org>
Date: Thu Jun 30 10:15:47 2016

Add color-profile related gpu-rasterization LayoutTests to TestExpectations

BUG=624709
TBR=noel@chromium.org

Review-Url: https://codereview.chromium.org/2104373003
Cr-Commit-Position: refs/heads/master@{#403137}

[modify] https://crrev.com/99b64d7535aaf9945e2031d71d59e29f8cbb799c/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by noel@chromium.org, Nov 2 2016

Cc: scroggo@chromium.org msarett@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 4 by noel@chromium.org, Feb 1 2017

Summary: Build failure: some force-gpu-rasterization tests changed color (was: Build failure: some force-gpu-rasterization tests are flakey)
No revision range provided in the OP.  These tests have never been flakey.  What appears to have happened is that the tests changed color.

Comment 5 by noel@chromium.org, Feb 1 2017

Owner: fmalita@chromium.org
I'm suspecting a skia roll around the time of the report was responsible, but with no revision range..

+Florian.  Looking at TestExpectations, I found

# TODO(fmalita): re-enable
# crbug.com/624709 [ Win ] virtual/gpu-rasterization/images/png-with-color-profile.html [ Failure ]

Shall we re-enble?

crbug.com/624709 [ Win ] virtual/gpu-rasterization/images/webp-color-profile-lossy.html [ Failure ]

Looking the image diff here, I expect a rebaseline is needed.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54

commit 573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54
Author: schenney <schenney@chromium.org>
Date: Thu Apr 06 22:09:38 2017

Rebaseline some color profile tests

virtual/gpu-rasterization/images/webp-color-profile-lossy.html
is passing, it seems, and needs new baselines.

virtual/gpu-rasterization/images/color-profile-filter.html
seems to be passing everywhere already.

virtual/gpu-rasterization/images/color-profile-background-clip-text.html
is no longer crashing and produces consistent result, but those results
are wrong due to crbug.com/670292. So rebaseline until we fix the bug.

TBR=noel@chromium.org
BUG=624709,587737, 624233 

Review-Url: https://codereview.chromium.org/2794403002
Cr-Commit-Position: refs/heads/master@{#462642}

[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/205ee990e92962dbe5a0cceed476680c055c43b1/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-filter-expected.png
[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[delete] https://crrev.com/205ee990e92962dbe5a0cceed476680c055c43b1/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png
[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[delete] https://crrev.com/205ee990e92962dbe5a0cceed476680c055c43b1/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[add] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[add] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[delete] https://crrev.com/205ee990e92962dbe5a0cceed476680c055c43b1/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[modify] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png
[add] https://crrev.com/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png
[delete] https://crrev.com/205ee990e92962dbe5a0cceed476680c055c43b1/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png

Project Member

Comment 8 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment