Non Regression : Spacing issue is seen in chrome://md-settings page. |
|||||||||
Issue descriptionVersion: 53.0.2782.6/ 8523.0.0 (Official Build) dev-channel auron_paine, Peppy, Daisy OS: Chrome What steps will reproduce the problem? (1) Sign in to user -> launch browser and go to chrome://md-settings. (2) Click on Advanced and observe Date and Time settings. Expected: Spacing issue should not been seen in Date and time settings Actual : Instead spacing issue is seen in Date and Time settings. (Refer screenshot) This is a non-regression issue seen since introduction of md-settings in M-48. Issue is not seen in Linux
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2016
,
Nov 22 2016
Spacing looks correct now with https://codereview.chromium.org/2438443005 and https://codereview.chromium.org/2447343002.
,
Nov 28 2016
'Time zone:' title text is missing above the Time zone dropdown. Attached screenshot from old Settings and MD Settings. Please close if this is WAI.
,
Dec 6 2016
#5: Thanks, good catch. Should be straightforward to do something similar to the autofill dialog.
,
Feb 16 2017
Taking this one over.
,
Feb 17 2017
bettes@ - I don't see a spec for Date & time, but it does seem like there should be a label for this on the left with the dropdown on the right, same as other dropdowns, e.g. Search engine?
,
Feb 17 2017
Ugh, wrong issu, ignore that.
,
Feb 17 2017
New mocks posted. We should move the "Set time zone automatically" switch to the top of the card, and have the time zone dropdown indented as a child of that control. The dropdown should be disabled when setting is ON, enabled when setting is OFF. https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Date_time.png%3Fz=width
,
Feb 17 2017
Looks great, thanks!
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df7c768a829d848bc7ff934d6ed3b20bdb9529d9 commit df7c768a829d848bc7ff934d6ed3b20bdb9529d9 Author: stevenjb <stevenjb@chromium.org> Date: Tue Feb 21 20:05:53 2017 MD Settings: Fix date and time layout BUG= 624707 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2704733002 Cr-Commit-Position: refs/heads/master@{#451825} [modify] https://crrev.com/df7c768a829d848bc7ff934d6ed3b20bdb9529d9/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html [modify] https://crrev.com/df7c768a829d848bc7ff934d6ed3b20bdb9529d9/chrome/browser/resources/settings/date_time_page/date_time_page.html [modify] https://crrev.com/df7c768a829d848bc7ff934d6ed3b20bdb9529d9/chrome/browser/resources/settings/device_page/pointers.html [modify] https://crrev.com/df7c768a829d848bc7ff934d6ed3b20bdb9529d9/chrome/browser/resources/settings/settings_vars_css.html
,
Feb 21 2017
,
Mar 29 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by brajkumar@chromium.org
, Jun 30 2016