Regression: Drop down text is not centre aligned on ‘Md-settings/language’
Reported by
dmascare...@etouch.net,
Jun 30 2016
|
||||||
Issue descriptionChrome Version:Chrome Version:53.0.2784.0 (Official Build) Revision 642ae4ba1dc7b04a1d480d733cdced28de720e00-refs/heads/master@{#403038} OS:Windows (7,8,10),Mac(10.10.5) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/ 2. Click on ‘Advanced’ and then click on dropdown arrow beside ‘English’ under ‘Language’section. 3. Click on first iron icon and observe option overlay. Actual: Drop down text is not centre aligned Expected: Drop down text should be centre aligned This is regression issue, broken in ‘M 53’ and narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/c43e0bb044f911727bcb340753de1fe03514a2ff..7386c581f1a62b85a1bd1d0224d0414a7dad0d9f Suspect: r402981 ? Good build:53.0.2783.2 Bad build:53.0.2785.0 Note: Will soon update Linux info.
,
Jun 30 2016
,
Jun 30 2016
Looking into this. At first glance it seems that https://codereview.chromium.org/2106723003/diff/100001/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html unexpectedly affected <paper-item> instances styles.
,
Jun 30 2016
It seems that after the change in paper-item shared styles, all paper-item instances have display:block instead of display:flex, which causes the center alignment bug. @michaelpg: Should we revert the Polymer change? Or is there a smaller fix we can apply?
,
Jun 30 2016
+noms
It's weird that paper-item-shared-styles.html has
:host {
display: block;
}
while paper-item.html has
:host {
@apply(--layout-horizontal)
}
which of course sets display: flex.
After changing :host to :host(paper-item) in paper-item-shared-styles.html, I guess we need to make the same change in paper-item.html as well to keep the same specificity. But why do these two files have different display properties in the first place?
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c8d8e76c18e1f0451269fe59bd71fb6be4701af commit 9c8d8e76c18e1f0451269fe59bd71fb6be4701af Author: dpapad <dpapad@chromium.org> Date: Thu Jun 30 23:30:03 2016 Revert "MD Settings: Improve rendering performance of fonts page." This reverts commit 9a07dc6b71462795d776490acb1e51142c9afd74. Broke styling of paper-item. BUG= 624680 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2119733002 Cr-Commit-Position: refs/heads/master@{#403335} [modify] https://crrev.com/9c8d8e76c18e1f0451269fe59bd71fb6be4701af/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/9c8d8e76c18e1f0451269fe59bd71fb6be4701af/chrome/browser/resources/settings/controls/settings_dropdown_menu.html [modify] https://crrev.com/9c8d8e76c18e1f0451269fe59bd71fb6be4701af/third_party/polymer/v1_0/chromium.patch [modify] https://crrev.com/9c8d8e76c18e1f0451269fe59bd71fb6be4701af/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html
,
Jul 1 2016
,
Jul 1 2016
,
Jul 7 2016
Retested the above issue on All-OS(Windows, Mac 10.11.5 & Ubuntu 14.04) with chrome version '53.0.2785.8' & options overlay under the setting> Languages section is center align. Hence marking the same as TE-Verified-53.0.2785.8. Thank you! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dmascare...@etouch.net
, Jun 30 2016Note: 1.Above issue is seen on ‘MD- Downloads’ , ‘MD-History’ ,’MD-Switch Person overlay’, please refer the attached screenshot. 2.Above issue is seen on Linux, Mac Pro(10.11.4) and Mac Retina(10.11.5)105 KB
105 KB View Download