New issue
Advanced search Search tips

Issue 624672 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 426656



Sign in to add a comment

Determine Per-Monitor DPI For Stable

Project Member Reported by robliao@chromium.org, Jun 30 2016

Issue description

Determine if Per-Monitor DPI should continue to stable.
 
Blocking: 426656
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c110f1855d378172bcb74e0c26640bfc0d35d02d

commit c110f1855d378172bcb74e0c26640bfc0d35d02d
Author: robliao <robliao@chromium.org>
Date: Thu Jun 30 23:16:47 2016

Enable Per-Monitor Support for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10.

BUG= 426656 , 624672 

Review-Url: https://codereview.chromium.org/2114503002
Cr-Commit-Position: refs/heads/master@{#403329}

[modify] https://crrev.com/c110f1855d378172bcb74e0c26640bfc0d35d02d/chrome/app/chrome_exe_main_win.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c28de990fa24222973d9b462ee7eab89cf896e1

commit 1c28de990fa24222973d9b462ee7eab89cf896e1
Author: robliao <robliao@chromium.org>
Date: Fri Jul 01 17:05:33 2016

Revert of Enable Per-Monitor Support for Windows 10 (patchset #3 id:40001 of https://codereview.chromium.org/2114503002/ )

Reason for revert:
Causes maximized incognito windows to render blank.

Original issue's description:
> Enable Per-Monitor Support for Windows 10
>
> This allows Chrome to render at the native resolution on each display on
> Windows 10.
>
> BUG= 426656 , 624672 
>
> Committed: https://crrev.com/c110f1855d378172bcb74e0c26640bfc0d35d02d
> Cr-Commit-Position: refs/heads/master@{#403329}

TBR=thestig@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 426656 , 624672 , 625046 

Review-Url: https://codereview.chromium.org/2115963002
Cr-Commit-Position: refs/heads/master@{#403472}

[modify] https://crrev.com/1c28de990fa24222973d9b462ee7eab89cf896e1/chrome/app/chrome_exe_main_win.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e6e31b4b73153f190507e49ab9caa4634ff497f

commit 8e6e31b4b73153f190507e49ab9caa4634ff497f
Author: robliao <robliao@chromium.org>
Date: Fri Jul 01 22:28:43 2016

Add Per-Monitor DPI Switches for Windows 10

This allows Chrome to render at the native resolution on each display on
Windows 10 when --enable-per-monitor-dpi is specified.

--disable-per-monitor-dpi will correspondingly disable the feature, even if
--enable-per-monitor-dpi is specified.

Once I have more confidence in the change, I'll flip the default.
--enable-per-monitor-dpi will override --disable-per-monitor-dpi.

At the every end of the process, I'll remove the flags.

BUG= 426656 , 624672 ,625289

Review-Url: https://codereview.chromium.org/2118953002
Cr-Commit-Position: refs/heads/master@{#403551}

[modify] https://crrev.com/8e6e31b4b73153f190507e49ab9caa4634ff497f/chrome/app/chrome_exe_main_win.cc
[modify] https://crrev.com/8e6e31b4b73153f190507e49ab9caa4634ff497f/chrome/common/chrome_switches.cc
[modify] https://crrev.com/8e6e31b4b73153f190507e49ab9caa4634ff497f/chrome/common/chrome_switches.h

Status: WontFix (was: Assigned)
Since this is now gated by a flag, we don't need to make this determination anymore for M53.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 1 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87d5cd10e2b9946ec8d33798268b07b336574e35

commit 87d5cd10e2b9946ec8d33798268b07b336574e35
Author: Robert Liao <robliao@chromium.org>
Date: Fri Jul 01 23:44:16 2016

Revert of Enable Per-Monitor Support for Windows 10 (patchset #3 id:40001 of https://codereview.chromium.org/2114503002/ )

Reason for revert:
Causes maximized incognito windows to render blank.

Original issue's description:
> Enable Per-Monitor Support for Windows 10
>
> This allows Chrome to render at the native resolution on each display on
> Windows 10.
>
> BUG= 426656 , 624672 
>
> Committed: https://crrev.com/c110f1855d378172bcb74e0c26640bfc0d35d02d
> Cr-Commit-Position: refs/heads/master@{#403329}

TBR=thestig@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 625046 

Review-Url: https://codereview.chromium.org/2115963002
Cr-Commit-Position: refs/heads/master@{#403472}
(cherry picked from commit 1c28de990fa24222973d9b462ee7eab89cf896e1)

Review URL: https://codereview.chromium.org/2119983003 .

Cr-Commit-Position: refs/branch-heads/2785@{#4}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/87d5cd10e2b9946ec8d33798268b07b336574e35/chrome/app/chrome_exe_main_win.cc

Sign in to add a comment