Issue 624668 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	hirosh...@chromium.org
Closed:	Jul 2016
Cc:	kinuko@chromium.org tzik@chromium.org haraken@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Rename WTF::bind()-related names

Project Member Reported by hirosh...@chromium.org, Jun 30 2016

Issue description

Convention will be:
- Use a short name for same-thread things:
    bind()
    Closure
    unretained()
    (Persistent, WeakPersistent)
- Use names with "crossThread" prefix for cross-thread things:
    crossThreadBind()
    CrossThreadClosure
    crossThreadUnretained()
    (CrossThreadPersistent, CrossThreadWeakPersistent)

Comment 1 by hirosh...@chromium.org, Jun 30 2016

Also, bind() will be fully-prefixed WTF::bind() to avoid confusion with std::bind() due to ADL by std::unique_ptr.

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c

commit f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c
Author: hiroshige <hiroshige@chromium.org>
Date: Thu Jun 30 05:29:14 2016

Specify WTF:: prefix for bind()

To avoid ambiguous resolutions to std::bind() (due to ADL and std::unique_ptr),
this CL removes |using WTF::bind| and adds the WTF:: prefix to bind()
where needed.

BUG= 624668 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2108033005
Cr-Commit-Position: refs/heads/master@{#403094}

[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/platform/SharedBuffer.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/f90e7ac5ce6cd2e552d1bfad6c58bd51bac2f76c/third_party/WebKit/Source/wtf/Functional.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81302ccc1ab99c659e8f8dfd40adcf96b4604884

commit 81302ccc1ab99c659e8f8dfd40adcf96b4604884
Author: hiroshige <hiroshige@chromium.org>
Date: Thu Jun 30 21:13:55 2016

Rename SameThreadClosure to Closure

BUG= 624668 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2110363002
Cr-Commit-Position: refs/heads/master@{#403287}

[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/bindings/core/v8/Microtask.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/bindings/core/v8/Microtask.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/core/workers/WorkerScriptLoader.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/ContentSettingCallbacks.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/ContentSettingCallbacks.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/WebThreadSupportingGC.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/heap/PersistentTest.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/wtf/Functional.h
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/Source/wtf/FunctionalTest.cpp
[modify] https://crrev.com/81302ccc1ab99c659e8f8dfd40adcf96b4604884/third_party/WebKit/public/platform/WebTaskRunner.h

Comment 4 by hirosh...@chromium.org, Jul 6 2016

Status: Fixed (was: Started)

►

Issue 624668 link

Issue metadata

Rename WTF::bind()-related names

Issue description

Comment 1 by hirosh...@chromium.org, Jun 30 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jun 30 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jun 30 2016

Comment 3 Deleted

Comment 4 by hirosh...@chromium.org, Jul 6 2016

Comment 4 Deleted

Sign in to add a comment