MacViews: Redundant character inserted by IME. |
||
Issue descriptionVersion: 53.0.2784.0 OS: Mac What steps will reproduce the problem? (1) Enable MacViews. (2) Open a Views textfield. (e.g. Bookmark bubble). (3) Press and Hold 'a' key (4) 'a' is entered in the textfield and an IME popup will appear with various choices. (5) Press right arrow key. What is the expected output? The inserted 'a' is replaced with the IME selection. What do you see instead? The inserted 'a' stays as it is and a new character is inserted corresponding to the IME selection. The reason most probably is that we don't honor the replacementRange attribute in setMarkedText:selectedRange:replacementRange method in BridgedContentView. This works fine in the renderer.
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89e44b6df97a0f5c63586de6a9716b4e18339c23 commit 89e44b6df97a0f5c63586de6a9716b4e18339c23 Author: karandeepb <karandeepb@chromium.org> Date: Thu Jul 28 03:47:35 2016 MacViews: Fix setMarkedText in BridgedContentView to take replacementRange into account. This CL changes setMarkedText:selectedRange:replacementRange: method implemented by BridgedContentView to take replacementRange parameter into account. This prevents the insertion of redudant characters by the IME, when accented characters are input. Also, a test is added which fails on the current master. BUG= 624657 Review-Url: https://codereview.chromium.org/2177853002 Cr-Commit-Position: refs/heads/master@{#408331} [modify] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/89e44b6df97a0f5c63586de6a9716b4e18339c23/ui/views/cocoa/bridged_native_widget_unittest.mm
,
Jul 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by karandeepb@chromium.org
, Jun 30 2016