Build failure: Payments related tests in chrome_public_test_apk are flakey. |
||||||
Issue descriptionBuild is broken: chrome_public_test_apk Revision range: chromium 402930 : 402961 Failing builders: Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)
,
Jun 30 2016
,
Jun 30 2016
Root cause: Caused by: java.lang.AssertionError at org.chromium.chrome.browser.payments.ui.EditorFieldModel.setValue(EditorFieldModel.java:176)
,
Jun 30 2016
The assert that's triggered: assert mInputTypeHint != INPUT_TYPE_HINT_DROPDOWN; Probably not a timing issue, but a test using the wrong API to update the dropdown selection.
,
Jun 30 2016
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5478255cd31bffa2867db84946f9512cba5a3fd commit e5478255cd31bffa2867db84946f9512cba5a3fd Author: rouslan <rouslan@chromium.org> Date: Thu Jun 30 03:58:24 2016 Remove incorrect assert in PaymentRequest address editor UI. The address editor in PaymentRequest UI needs to set the value of the country dropdown when editing or create a new shipping address. This change to the dropdown should not fire a callback that re-arranges the address input fields. This is accomplished via the EditorFieldModel.setValue() call. Therefore, asserting that setValue() is not used for dropdowns is incorrect. The mCountryField.setValue() call has been moved below the mCountryField.setDropdownCallback() to make it clear to the reader that the callback is not fired intentionally, instead of accidentally. BUG= 624653 TBR=dfalcantara Review-Url: https://codereview.chromium.org/2110013003 Cr-Commit-Position: refs/heads/master@{#403085} [modify] https://crrev.com/e5478255cd31bffa2867db84946f9512cba5a3fd/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/e5478255cd31bffa2867db84946f9512cba5a3fd/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
,
Jun 30 2016
horo@, This particular failure should be fixed. If you notice something else still failing, please let me know.
,
Jun 30 2016
It is still failing in EditorView.java. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35099 failures: org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest#testChangeCountryAddAddressAndPay I 852.429s run_tests_on_device(0cba90a3032fdbe3) detected failure in org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest#testChangeCountryAddAddressAndPay. raw output: I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: numtests=1 I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: stream= I 852.429s run_tests_on_device(0cba90a3032fdbe3) org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest: I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: id=InstrumentationTestRunner I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: test=testChangeCountryAddAddressAndPay I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: current=1 I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS_CODE: 1 I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: test=testChangeCountryAddAddressAndPay I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.ChromeActivityTestCaseBase$ChromeUncaughtExceptionHandler I 852.429s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS: stack=java.lang.AssertionError I 852.430s run_tests_on_device(0cba90a3032fdbe3) at org.chromium.chrome.browser.payments.ui.EditorView.prepareEditor(EditorView.java:246) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at org.chromium.chrome.browser.payments.ui.EditorView.access$400(EditorView.java:50) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at org.chromium.chrome.browser.payments.ui.EditorView$5.run(EditorView.java:231) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at android.os.Handler.handleCallback(Handler.java:733) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at android.os.Handler.dispatchMessage(Handler.java:95) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at android.os.Looper.loop(Looper.java:136) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at android.app.ActivityThread.main(ActivityThread.java:5001) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at java.lang.reflect.Method.invokeNative(Native Method) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at java.lang.reflect.Method.invoke(Method.java:515) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601) I 852.430s run_tests_on_device(0cba90a3032fdbe3) at dalvik.system.NativeStart.main(Native Method) I 852.430s run_tests_on_device(0cba90a3032fdbe3) I 852.430s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_STATUS_CODE: -1 I 852.430s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_RESULT: shortMsg=java.lang.AssertionError I 852.430s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_RESULT: longMsg=java.lang.AssertionError I 852.431s run_tests_on_device(0cba90a3032fdbe3) INSTRUMENTATION_CODE: 0
,
Jun 30 2016
Will take a look tomorrow.
,
Jun 30 2016
I will disable it. https://codereview.chromium.org/2115483002/
,
Jun 30 2016
Sgtm. Issue is the assert in https://codesearch.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java?q=Editorview&sq=package:chromium&l=246 that checks for only one phone number field. However the code recreates all fields when the country dropdown changes. The correct logic should be to cash and reuse the phone number field. Does that sound right, dfalcantara@?
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22912b1b5d22a3c5168381ea7de33ce5beb5db32 commit 22912b1b5d22a3c5168381ea7de33ce5beb5db32 Author: horo <horo@chromium.org> Date: Thu Jun 30 08:12:31 2016 Disable PaymentRequestFreeShippingTest#testChangeCountryAddAddressAndPay BUG= 624653 TBR=rouslan@chromium.org Review-Url: https://codereview.chromium.org/2115483002 Cr-Commit-Position: refs/heads/master@{#403119} [modify] https://crrev.com/22912b1b5d22a3c5168381ea7de33ce5beb5db32/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
,
Jun 30 2016
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a474a14a78932c7551fabf03981bbe4427f7c1b2 commit a474a14a78932c7551fabf03981bbe4427f7c1b2 Author: rouslan <rouslan@chromium.org> Date: Thu Jun 30 17:52:59 2016 Fix assert and re-enable tests for PaymentRequest. BUG= 624653 Review-Url: https://codereview.chromium.org/2116563002 Cr-Commit-Position: refs/heads/master@{#403217} [modify] https://crrev.com/a474a14a78932c7551fabf03981bbe4427f7c1b2/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/a474a14a78932c7551fabf03981bbe4427f7c1b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [modify] https://crrev.com/a474a14a78932c7551fabf03981bbe4427f7c1b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java
,
Jun 30 2016
horo@, if you still see failures, please re-open and/or ping me.
,
Jun 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by horo@chromium.org
, Jun 30 2016Status: Assigned (was: Available)