New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624651 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Build failure: virtual/threaded/fast/compositorworker/visual-update.html on WebKit Linux (dbg)

Project Member Reported by horo@chromium.org, Jun 30 2016

Issue description

Build is broken:
webkit_tests virtual/threaded/fast/compositorworker/visual-update.html
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Ffast%2Fcompositorworker%2Fvisual-update.html&testType=webkit_tests

Revision range:
chromium 402959 : 402999

Failing builders:
WebKit Linux (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)


 
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba9a8fbcce17e50e5006a008041301b934cde6f0

commit ba9a8fbcce17e50e5006a008041301b934cde6f0
Author: majidvp <majidvp@chromium.org>
Date: Tue Jul 05 19:54:29 2016

[compositorworker] Avoid deadlock issue caused by importScript

importScripts is a sync API that runs on main thread. Using it on CW
will block the compositor thread on main which can lead to deallock in
the current Blink compositing architecture. So we should avoid it for
now.

TODO:
 - Find a way to throw if importScripts is used in CW. Current failure is
   subtle
 - Provide and alternative to synchronous importScripts. Note that async
   resource loading in already possible in workers thanks to fetch so we
   may be a able to leverage that.

BUG= 624651 
TEST=virtual/threaded/fast/compositorworker

Review-Url: https://codereview.chromium.org/2119383002
Cr-Commit-Position: refs/heads/master@{#403819}

[modify] https://crrev.com/ba9a8fbcce17e50e5006a008041301b934cde6f0/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/basic-plumbing-main-to-worker.js
[modify] https://crrev.com/ba9a8fbcce17e50e5006a008041301b934cde6f0/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/basic-plumbing-worker-to-main.js
[modify] https://crrev.com/ba9a8fbcce17e50e5006a008041301b934cde6f0/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js
[modify] https://crrev.com/ba9a8fbcce17e50e5006a008041301b934cde6f0/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-mutate.js
[modify] https://crrev.com/ba9a8fbcce17e50e5006a008041301b934cde6f0/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/visual-update.js
[delete] https://crrev.com/3528705e8b93d3a070f1d31e2dd355db1c33f52c/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/worker-common.js

Labels: Hotlist-Threaded-Rendering Type-Bug
Cc: flackr@chromium.org ajuma@chromium.org petewil@chromium.org majidvp@chromium.org penghuang@chromium.org vollick@chromium.org
 Issue 624023  has been merged into this issue.
Status: Fixed (was: Assigned)
Cc: sadrul@chromium.org
 Issue 624712  has been merged into this issue.

Sign in to add a comment