Issue metadata
Sign in to add a comment
|
Menu UI does not show green dots when an update is available |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2774.3/dev OS: OSX 10.11.5 In the latest dev channel update, the menu dots did not turn green when an update was available (see screenshot). I normally stay up to date so I suspect this is a recent regression and wanted to file it asap.
,
Jul 8 2016
spqchan@ - would you please look into this to see if the icon color change is broken? I'm also going to create a second bug about updating the three dots icon to display the new out-of-date browser warning icons. I thought the Mac would just pick them up but looking at the tracking bug it only changed Views.
,
Jul 11 2016
Sure thing, is there a good way to simulate the out-of-date browser experience?
,
Jul 11 2016
I believe the --simulate-upgrade does that.
,
Jul 11 2016
Hmm, --simulate-upgrade didn't do what I would expect. It's possible one of the simulate flags does though: http://peter.sh/experiments/chromium-command-line-switches/
,
Jul 11 2016
I see, thanks! I'll give this a true
,
Jul 11 2016
Interestingly, --simulate-critical-update seems to work, but not --simulate-upgrade Looking into the code, it looks like it's supposed to simulate an upgrade: https://cs.chromium.org/chromium/src/chrome/browser/upgrade_detector_impl.cc?rcl=0&l=214 I created Issue 627249 for this problem
,
Jul 11 2016
Never mind, it looks like --simulate-upgrade works. You just need to wait 20 seconds for the "low threshold" update to show up.
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96 commit bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96 Author: spqchan <spqchan@chromium.org> Date: Thu Jul 14 19:12:08 2016 [Material][Mac] Update App Menu Icons and Colors Change the "Low Severity" color to Green. Update the icons to the MD ones. BUG= 624643 , 626775 Review-Url: https://codereview.chromium.org/2139573003 Cr-Commit-Position: refs/heads/master@{#405532} [modify] https://crrev.com/bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.h [modify] https://crrev.com/bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm [modify] https://crrev.com/bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
,
Aug 31 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ccameron@chromium.org
, Jul 1 2016Status: Assigned (was: Untriaged)