New issue
Advanced search Search tips

Issue 624640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Rename AnimationStack as EffectStack

Project Member Reported by suzyh@chromium.org, Jun 30 2016

Issue description

EffectStack is a clearer name for what the class represents than AnimationStack.
 

Comment 1 by suzyh@chromium.org, Jun 30 2016

Something else to consider: this stack may contain SVG animations but not SMIL animations. There might be something to do here with naming or code organization to make it clearer that this is the case / why it is the case.
Indeed, what used to be called Animations are now called AnimationEffects.

Comment 3 by suzyh@chromium.org, Oct 5 2016

Labels: Hotlist-Squash-A-Bug

Comment 4 by loyso@chromium.org, Nov 22 2016

Owner: loyso@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccb91fd6df446c3168d2f24f78749430c5177357

commit ccb91fd6df446c3168d2f24f78749430c5177357
Author: loyso <loyso@chromium.org>
Date: Wed Nov 23 00:53:30 2016

Blink Animation: Rename AnimationStack to EffectStack.

BUG= 624640 

Review-Url: https://codereview.chromium.org/2522823002
Cr-Commit-Position: refs/heads/master@{#434045}

[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/BUILD.gn
[rename] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/EffectStack.cpp
[rename] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/EffectStack.h
[rename] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/EffectStackTest.cpp
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/ElementAnimations.h
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/ccb91fd6df446c3168d2f24f78749430c5177357/third_party/WebKit/Source/core/svg/SVGElement.cpp

Comment 6 by loyso@chromium.org, Nov 23 2016

Status: Fixed (was: Started)

Sign in to add a comment