New issue
Advanced search Search tips

Issue 624638 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 654309



Sign in to add a comment

Move conversion checkers out of InterpolationTypes

Project Member Reported by suzyh@chromium.org, Jun 30 2016

Issue description

It's not clear that ConversionChecker and its subclasses should be members of InterpolationType and its subclasses. It increases the risk of code duplication and makes it harder to browse the code.
 
SGTM.

I think ConversionChecker was made a subclass of InterpolationType for the sake of scoping the name to interpolation code. I doubt there'd be conflicts with this name in future though and even if there is we can put it back.

Not sure how code duplication is a factor though.

Comment 2 by suzyh@chromium.org, Oct 10 2016

Blocking: 654309
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 10 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 11

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)

Sign in to add a comment