New issue
Advanced search Search tips

Issue 624636 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 654309



Sign in to add a comment

Conversion checkers have inconsistent naming

Project Member Reported by suzyh@chromium.org, Jun 30 2016

Issue description

The conversion checkers use inconsistent naming between 'parent' and 'inherited' conversion checkers, but these mean the same thing.
 

Comment 1 by suzyh@chromium.org, Oct 5 2016

Labels: Hotlist-Squash-A-Bug
Owner: ericwilligers@chromium.org
Status: Assigned (was: Available)

Comment 2 by suzyh@chromium.org, Oct 10 2016

Blocking: 654309
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/071321870a524994c10d0c7a89dd5db533712a8d

commit 071321870a524994c10d0c7a89dd5db533712a8d
Author: ericwilligers <ericwilligers@chromium.org>
Date: Wed Oct 26 09:40:03 2016

Web Animations: consistent naming for parent style checkers

Interpolations to or from 'inherit' check if the parent style has
changed. The checking classes now have a consistent naming convention:
Inherited<property>Checker.

BUG= 624636 

Review-Url: https://codereview.chromium.org/2453573003
Cr-Commit-Position: refs/heads/master@{#427649}

[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/071321870a524994c10d0c7a89dd5db533712a8d/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

Status: Fixed (was: Started)

Sign in to add a comment