InterpolationType hierarchy should have static create methods |
||||||||
Issue descriptionThe InterpolationTypes should have static ::create methods and private constructors instead of public constructors. The logic of PropertyInterpolationTypesMapping should be moved here as well. In doing so we might also be able to move away from switch/if-else logic.
,
Jun 30 2016
I'll take this to give it some thought.
,
Jun 30 2016
BTW static create() methods SGTM, the other ideas brought up are orthogonal.
,
Oct 6 2016
TODO: investigate whether the discussion of MakeUnique() and WrapUnique() affects this. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Bo_4JqYXaiE
,
Oct 10 2016
,
Jan 11 2017
I'm not likely to work on this soon, so making it Available. I'm actively working on the broader Objective (issue 654309), however, and happy to brief someone if they want to take it up before I get back to it.
,
Jan 11 2017
Could you clarify whether the switch/if-else thing is part of this bug? The title suggests something orthogonal.
,
Jan 11 2017
Hmm, no, it shouldn't be. This bug only specifically deals with the static ::create functions. My intuition at the time was that if the inheritance hierarchy is approached correctly (for some as-yet-unclear value of 'correct'), then switch/if-else and property map logic would not be required. I think there are connected design problems (well, question marks) here, but let's leave this bug to be only about the static create methods, and address the switch/if-else logic separately if it becomes appropriate.
,
Jan 20 2017
,
Jun 13 2017
,
Jun 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by alancutter@chromium.org
, Jun 30 2016