New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624621 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
OOO until 2019-01-24
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 624599

Blocking:
issue 490984



Sign in to add a comment

Get build90-b1 (Pixel C) green

Project Member Reported by kbr@chromium.org, Jun 30 2016

Issue description

https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20(Pixel%20C) is a newly-deployed Pixel C for GPU testing on Android. A few tests are failing on it and should be investigated and/or suppressed to get the bot reliably green.

 

Comment 1 by kbr@chromium.org, Jul 22 2016

Cc: cblume@chromium.org vmi...@chromium.org ynovikov@chromium.org
WebglConformance_conformance_glsl_bugs_constant_precision_qualifier is failing reliably.

WebglConformance_conformance_textures_video* seem to be flaky, but occasionally passing.

A lot of gl_tests are failing on this device with:

I   16.565s run_tests_on_device(5B24001812)  [----------] 3 tests from EXTMultisampleCompatibilityTest
I   16.565s run_tests_on_device(5B24001812)  [ RUN      ] EXTMultisampleCompatibilityTest.TestSimple
I   16.565s run_tests_on_device(5B24001812)  [ERROR:gpu_test_config.cc(261)] Fail to identify GPU

Not sure why this is working (and not reporting errors) on the other Android devices. It might be that some of these tests are only running because this device exposes a lot more extensions than others.

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3aa15c537b8a105184e0bf25a1f5de3ef8c875a

commit a3aa15c537b8a105184e0bf25a1f5de3ef8c875a
Author: kbr <kbr@chromium.org>
Date: Sat Jul 23 03:58:52 2016

Change naming convention for Android pixel reference images.

The Nexus 9 and Pixel C on the waterfall have the same GPU device string
but different screen resolutions, causing collisions between their pixel
test reference images. Add in the model name ("Nexus 9", "AOSP on
dragon") to disambiguate them.

BUG= 624621 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org

Review-Url: https://codereview.chromium.org/2176003002
Cr-Commit-Position: refs/heads/master@{#407348}

[modify] https://crrev.com/a3aa15c537b8a105184e0bf25a1f5de3ef8c875a/content/test/gpu/gpu_tests/cloud_storage_test_base.py
[modify] https://crrev.com/a3aa15c537b8a105184e0bf25a1f5de3ef8c875a/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa99476e6e90fc15c59e5f59e45014fd771ead72

commit fa99476e6e90fc15c59e5f59e45014fd771ead72
Author: kbr <kbr@chromium.org>
Date: Sun Jul 24 03:33:33 2016

On Pixel C, suppress WebGL test failures and stop running gl_tests for now.

BUG= 624621 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org

Review-Url: https://codereview.chromium.org/2177723002
Cr-Commit-Position: refs/heads/master@{#407379}

[modify] https://crrev.com/fa99476e6e90fc15c59e5f59e45014fd771ead72/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/fa99476e6e90fc15c59e5f59e45014fd771ead72/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/fa99476e6e90fc15c59e5f59e45014fd771ead72/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80b5d0ec0918b864df45dca951931aea3678826b

commit 80b5d0ec0918b864df45dca951931aea3678826b
Author: kbr <kbr@chromium.org>
Date: Sun Jul 24 16:47:56 2016

Re-enable pixel tests on Android.

BUG= 624621 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cblume@chromium.org,ynovikov@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2175183002
Cr-Commit-Position: refs/heads/master@{#407388}

[modify] https://crrev.com/80b5d0ec0918b864df45dca951931aea3678826b/content/test/gpu/gpu_tests/pixel_expectations.py

Looks like it's green now https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Pixel%20C%29/builds/571
I guess this issue has been fixed. Unless you want to keep this bug for unsupressing tests?

Comment 6 by vmi...@chromium.org, Jul 26 2016

kbr@ stopped running gl_tests on the device in #3, which we'll want to get back on still.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e739d93f9cd9ce78965424cbf516570baf40a39

commit 1e739d93f9cd9ce78965424cbf516570baf40a39
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Wed Feb 08 23:28:19 2017

Update WebGL CTS expectations on Pixel

Please add them back if the bots turn red. I checked recent bot builders
that these tests passed.

BUG= 624621 
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2681843003
Cr-Commit-Position: refs/heads/master@{#449137}

[modify] https://crrev.com/1e739d93f9cd9ce78965424cbf516570baf40a39/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8564d2558144399265526b404d21ab589d2e8d92

commit 8564d2558144399265526b404d21ab589d2e8d92
Author: ynovikov <ynovikov@chromium.org>
Date: Fri May 19 01:50:00 2017

Remove Android Release (Pixel C) from GPU.FYI

BUG=723065,  624621 
TBR=kbr@chromium.org, dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2890073002
Cr-Commit-Position: refs/heads/master@{#473025}

[modify] https://crrev.com/8564d2558144399265526b404d21ab589d2e8d92/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/8564d2558144399265526b404d21ab589d2e8d92/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/8564d2558144399265526b404d21ab589d2e8d92/tools/mb/mb_config.pyl

Comment 9 by kbr@chromium.org, Sep 8 2017

Status: WontFix (was: Assigned)
This bot was unreliable and has been removed.

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edb9daff1efe0710675729e4409a9f94845971b8

commit edb9daff1efe0710675729e4409a9f94845971b8
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Sep 13 22:14:48 2017

Remove Pixel C WebGL CTS expectations

Since the bot was removed from the waterfall.

BUG= 624621 
TBR=kbr@chromium.org

Change-Id: Iabf02e72313bd2528d15df55e189b9b641e0b6e3
Reviewed-on: https://chromium-review.googlesource.com/665665
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501770}
[modify] https://crrev.com/edb9daff1efe0710675729e4409a9f94845971b8/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Sign in to add a comment