New issue
Advanced search Search tips

Issue 624614 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

chrome.webstore.install() can respond with errors different ways

Project Member Reported by rdevlin....@chromium.org, Jun 29 2016

Issue description

chrome.webstore.install() can respond with errors both from the renderer and from the browser.  In the renderer, this can also be by throwing an error, rather than responding to the failure callback.  It's difficult to change either of these cases since we don't know who may be relying on them.

One case that accentuates this is the case of having a pending install, where if the install is triggered by the same JS context, the renderer throws an exception, and otherwise the browser responds with an error.

We also currently only test the case of calling from the same JS context.

See also discussion at https://codereview.chromium.org/2103663002/diff/40001/chrome/browser/extensions/tab_helper.cc#newcode447

Note that if anyone wants to add a test for the separate JS contexts, an easy way would probably be by using a content script (or maybe from window.open, but I think we disallow installs from popups).
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 30 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 2

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
This is still annoying, but with inline install deprecated [1], I don't think we'll fix it.

[1] https://blog.chromium.org/2018/06/improving-extension-transparency-for.html

Sign in to add a comment