Title is missing on Files window when immediately switched to overview mode |
|||||||
Issue descriptionGoogle Chrome 53.0.2773.0 (Official Build) dev (64-bit) Revision 0 Platform 8517.0.0 (Official Build) dev-channel peppy What steps will reproduce the problem? 1. Open Browser 2. Open Files app 3. Immediately switch to Overview mode What do you see instead? Title is missing on Files app window. Attached screenshot
,
Jul 6 2016
Handing off to varkha@ for triage.
,
Jul 7 2016
This seems like an edge case, as you have to load overview immediately after launching the app, but before the app has time to update its title. Doesn't seem to be a M-53 blocker.
,
Jul 7 2016
Showing a blank title is pretty bad. Is this a long-standing issue, or was it introduced by MD Overview Mode? If it was introduced by us, we should fix it in M-53.
,
Jul 11 2016
#4, it is long-standing and is probably masked when a title gets updated from one long string to another. In this case it is updated from nothing to something and that needed some extra handling to update the view layout. Draft at https://codereview.chromium.org/2143473002/.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e commit 2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e Author: varkha <varkha@chromium.org> Date: Wed Jul 13 08:36:56 2016 [ash-md] Updates window title if it is changed after entering overview Need to call LabelButton::Layout since this requires updated preferred width of the label and that needs up to date text. BUG= 624612 Review-Url: https://codereview.chromium.org/2143473002 Cr-Commit-Position: refs/heads/master@{#405083} [modify] https://crrev.com/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e/ui/views/controls/button/label_button.cc [modify] https://crrev.com/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e/ui/views/controls/button/label_button_unittest.cc
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e commit 2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e Author: varkha <varkha@chromium.org> Date: Wed Jul 13 08:36:56 2016 [ash-md] Updates window title if it is changed after entering overview Need to call LabelButton::Layout since this requires updated preferred width of the label and that needs up to date text. BUG= 624612 Review-Url: https://codereview.chromium.org/2143473002 Cr-Commit-Position: refs/heads/master@{#405083} [modify] https://crrev.com/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e/ui/views/controls/button/label_button.cc [modify] https://crrev.com/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e/ui/views/controls/button/label_button_unittest.cc
,
Aug 12 2016
ChromeOS 54.0.2824.0/8696.0 samus |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Jul 1 2016