New issue
Advanced search Search tips

Issue 624608 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Shelf items misbehave in overview mode when too many windows are open

Project Member Reported by sdantul...@chromium.org, Jun 29 2016

Issue description

Google Chrome	53.0.2773.0 (Official Build) dev (64-bit)
Revision	0
Platform	8517.0.0 (Official Build) dev-channel peppy

What steps will reproduce the problem?
1. Open multiple windows
2. Switch to overview mode.
3. Hover mouse over shelf items Launcher, notification center, uber tray.

What do you see instead?
Launcher icon, notification center, and uber tray items disappear on hovering mouse over them.



 
Attached screenshot
IMG_20160629_162637.jpg
3.1 MB View Download
Cc: varkha@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 1 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-54 -MovedFrom-53 Proj-MaterialDesign-CrOS M-53
Owner: varkha@chromium.org
Status: Assigned (was: Untriaged)
Handing off to varkha@ for triage.
Labels: Needs-Feedback
Is this significantly different when setting --ash-md=disabled? Seems like the problem is pre-existing but would be great to know if the threshold when this starts happening has regressed.
 Issue 624606  has been merged into this issue.
Able to reproduce the issue with setting --ash-md=disabled. When this flag is disabled, the shelf items are missing even after exiting from overview mode .
Labels: -M-53 M-54 MovedFrom-53
Thanks, #7. I will punt this to M-54 to see if we can improve anything.
Labels: -Needs-Feedback
For me 17 windows are fine. Anything after that; craziness ensues 
Status: Started (was: Assigned)
I have a draft CL at https://codereview.chromium.org/2146323004/ that should improve the situation albeit at a cost of no longer hiding the window headers (but hiding the window controls) once the number of windows is large (>10).
I would like to get a feel if this is an acceptable trade-off.
That CL should also fix  issue 626851 , at least when there are many windows.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66

commit d8748a3907d55ade9282b8cf4d0993ac9ee5ab66
Author: varkha <varkha@chromium.org>
Date: Tue Jul 19 16:03:45 2016

[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG= 626851 
BUG= 624608 

Review-Url: https://codereview.chromium.org/2146323004
Cr-Commit-Position: refs/heads/master@{#406286}

[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/ash_switches.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/ash_switches.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/wm/panels/panel_frame_view.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/chrome/app/generated_resources.grd
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/chrome/browser/about_flags.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-53
Would be good to merge CL in #12 into M-53.

Comment 14 by shey...@google.com, Jul 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 26 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 26 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbfb5afbb61eac2a18e6b210ec4f40162357f612

commit fbfb5afbb61eac2a18e6b210ec4f40162357f612
Author: Valery Arkhangorodsky <varkha@chromium.org>
Date: Tue Jul 26 22:51:04 2016

[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG= 626851 
BUG= 624608 

Review-Url: https://codereview.chromium.org/2146323004
Cr-Commit-Position: refs/heads/master@{#406286}
(cherry picked from commit d8748a3907d55ade9282b8cf4d0993ac9ee5ab66)

Review URL: https://codereview.chromium.org/2184543005 .

Cr-Commit-Position: refs/branch-heads/2785@{#365}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/ash_switches.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/ash_switches.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/wm/panels/panel_frame_view.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/chrome/app/generated_resources.grd
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/chrome/browser/about_flags.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/tools/metrics/histograms/histograms.xml

Cc: abodenha@chromium.org sdantul...@chromium.org
 Issue 626851  has been merged into this issue.
Valery can this be moved to M-55 or is there still something you plan to fix and merge back into 54?
Labels: -M-54 M-55
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5d0098acc9a8167409476627eae3e91d94e8cac

commit f5d0098acc9a8167409476627eae3e91d94e8cac
Author: varkha <varkha@chromium.org>
Date: Fri Sep 09 22:06:20 2016

[ash-md] Fades overview header in and out

This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec.

This creates a visually smoother transition into overview mode than before.

Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item.

BUG= 624608 ,  645076 
TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt.

Review-Url: https://codereview.chromium.org/2239233002
Cr-Commit-Position: refs/heads/master@{#417728}

[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/aura/wm_window_aura.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/default_header_painter.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/header_view.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/frame/header_view.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/overview_animation_type.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/scoped_overview_animation_settings.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm_window.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/common/wm_window_property.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/overview/scoped_overview_animation_settings_aura.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/overview/scoped_overview_animation_settings_aura.h
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac/ui/aura/client/aura_constants.h

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/758e34e4a30be65c2cedf5fb2a893fa3a87596f0

commit 758e34e4a30be65c2cedf5fb2a893fa3a87596f0
Author: dmurph <dmurph@chromium.org>
Date: Sat Sep 10 01:50:58 2016

Revert of [ash-md] Fades overview header in and out (patchset #17 id:400001 of https://codereview.chromium.org/2239233002/ )

Reason for revert:
This is causing a use-after-free and crashing stuff :(

BUG= 645708 

Original issue's description:
> [ash-md] Fades overview header in and out
>
> This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec.
>
> This creates a visually smoother transition into overview mode than before.
>
> Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item.
>
> BUG= 624608 ,  645076 
> TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt.
>
> Committed: https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac
> Cr-Commit-Position: refs/heads/master@{#417728}

TBR=sky@chromium.org,bruthig@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 624608 ,  645076 

Review-Url: https://codereview.chromium.org/2329433003
Cr-Commit-Position: refs/heads/master@{#417796}

[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/aura/wm_window_aura.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/default_header_painter.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/header_view.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/frame/header_view.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/overview_animation_type.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/scoped_overview_animation_settings.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm_window.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/common/wm_window_property.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/overview/scoped_overview_animation_settings_aura.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/overview/scoped_overview_animation_settings_aura.h
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0/ui/aura/client/aura_constants.h

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc9b9dfb7982cf069897b750a76231ab5bb2e31

commit ebc9b9dfb7982cf069897b750a76231ab5bb2e31
Author: varkha <varkha@chromium.org>
Date: Mon Sep 12 20:07:30 2016

Reland of [ash-md] Fades overview header in and out

This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec.

This creates a visually smoother transition into overview mode than before.

Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item.

---

This relands https://codereview.chromium.org/2239233002/ and
reverts commit 758e34e4a30be65c2cedf5fb2a893fa3a87596f0.

Corrects lifetime manipulation of the child views after their
ownership it taken over by a CleanupAnimationObserver.

BUG= 624608 ,  645076 ,  645708 
TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt.

Review-Url: https://codereview.chromium.org/2336673002
Cr-Commit-Position: refs/heads/master@{#418017}

[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/aura/wm_window_aura.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/default_header_painter.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/header_view.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/frame/header_view.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/overview_animation_type.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/scoped_overview_animation_settings.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm_window.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/common/wm_window_property.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/overview/scoped_overview_animation_settings_aura.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/overview/scoped_overview_animation_settings_aura.h
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/ebc9b9dfb7982cf069897b750a76231ab5bb2e31/ui/aura/client/aura_constants.h

<triage>@varkha, what's the status of this?</triage>
I am hoping that https://codereview.chromium.org/2633643002/ (in review) and https://codereview.chromium.org/2627153006/ (landed as r443342) would have reduced texture memory consumption to make this better. Will need to wait to confirm on canary.
Labels: -M-55 M-57
Updating milestone to m-57.
Project Member

Comment 26 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4824ca45ebcccbdd2869310f366c1b178a4be85

commit d4824ca45ebcccbdd2869310f366c1b178a4be85
Author: varkha <varkha@chromium.org>
Date: Tue Jan 17 20:39:00 2017

[ash-md] Reduces dimensions of texture layers in overview mode

This CL simplifies the view structure of the visible items in overview
mode and reduces the dimensions of the texture layers used.

Previously each item was a widget (with a default texture layer)
that was sllightly bigger than the window and had a LabelButton covering
most of the area with a custom background. That background was only made
non-transparent in a caption above the window so the texture layer was
in fact unnecessarily large.
With this change the widget is created with a ui::LAYER_NOT_DRAWN layer
and only the narrow visible background behind the caption has a texture
layer (necessary to implement rounded corners for the visible caption).
The views structure has also been simplified. The view is covered by a
simple button (to capture events) and a simple Label is used in place
of the LabelButton.

BUG= 537050 ,  624608 
TEST=NONE - no visible change

Review-Url: https://codereview.chromium.org/2633643002
Cr-Commit-Position: refs/heads/master@{#444129}

[modify] https://crrev.com/d4824ca45ebcccbdd2869310f366c1b178a4be85/ash/ash_strings.grd
[modify] https://crrev.com/d4824ca45ebcccbdd2869310f366c1b178a4be85/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/d4824ca45ebcccbdd2869310f366c1b178a4be85/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/d4824ca45ebcccbdd2869310f366c1b178a4be85/ash/wm/overview/window_selector_unittest.cc

Labels: -M-57 M-58
Status: Assigned (was: Started)
Labels: -M-58
Cc: -tdander...@chromium.org -varkha@chromium.org wutao@chromium.org
Owner: ----
Status: Available (was: Assigned)
I won't be able to work on this anytime soon so returning to the queue for triage.
Labels: -Pri-2 Pri-3
Owner: wutao@chromium.org
Status: Assigned (was: Available)
wutao@ could you please try repro? I wasn't able to.

Comment 32 by wutao@chromium.org, Oct 24 2017

This looks like missing tiles when the memory is under stress, which depends what device you test. We probably cannot do too much in addition to reduce the memory usage for the overview mode.

varkha@ made some changes to improve the memory usage. Maybe we can close this by "Fixed"?

Comment 33 by wutao@chromium.org, Mar 15 2018

Status: Fixed (was: Assigned)
We had many changes recently to overview mode. I will close this bug for now.
Please feel free to reopen it or create a new one.

Thanks.

Sign in to add a comment