New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624604 link

Starred by 4 users
Status: Fixed
Owner:
martis@chromium.org
Closed: Nov 2017
Cc:
█ zkoch@chromium.org
yyushkina@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Translate bubble does not remember target language

Project Member Reported by juliecattiau@google.com, Jun 29 2016 
Steps to reproduce:
- translate twice from Spanish to French. 
- The next time you visit a Spanish website, Translate bubble suggests to "Always translate" Spanish to English. 

Expected behavior: 
- Translate bubble should suggest to "Always translate" Spanish to French, not to English.

More generally if we know users prefer to translate into lang X, the bubble should suggest to translate into this language.
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 30 2016

Labels: Hotlist-Google

Comment 2 by ftang@chromium.org, Jul 12 2016

Components: UI>Browser>Translate

Comment 3 by yyushkina@chromium.org, Apr 17 2017

Labels: Hotlist-Translate
Owner: yyushkina@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Translate UI>Browser>Language>Translate

Comment 5 by napper@chromium.org, May 5 2017

Cc: napper@chromium.org

Comment 6 by napper@chromium.org, Jul 26 2017

Labels: -Pri-1 Pri-2

Comment 7 by yyushkina@chromium.org, Nov 2 2017

Cc: -napper@chromium.org yyushkina@chromium.org
Owner: napper@chromium.org
Hey Jon - looks like we already have a bug tracking this behavior. Given that it's more of a bug than a feature, I don't actually think we need a PRD/design doc for this though we may still want to write out the details for 1) sync considerations (tl;dr :yes) and context menu-triggered translations (use the synced setting here too).

Comment 8 by napper@chromium.org, Nov 7 2017

Owner: martis@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32365f399cf6f0cd7387480ed95c439ac85ac0b7

commit 32365f399cf6f0cd7387480ed95c439ac85ac0b7
Author: Michael Martis <martis@chromium.org>
Date: Wed Nov 29 02:24:46 2017

Record and reuse most recent target language.

This change introduces a synced preference that tracks the language
that the user most-recently chose as a target language. This language
is then offered as the default target language.

Bug:  624604 
Change-Id: I8be60e81db2476e83707c090b34a0c6d955bbd25
Reviewed-on: https://chromium-review.googlesource.com/757882
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519975}
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/chrome/browser/ui/translate/translate_bubble_test_utils.h
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/chrome/browser/ui/views/translate/translate_bubble_test_utils_views.cc
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/chrome/browser/ui/views/translate/translate_language_browsertest.cc
[add] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/chrome/test/data/italian_page.html
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/32365f399cf6f0cd7387480ed95c439ac85ac0b7/components/translate/core/browser/translate_ui_delegate.cc

Comment 10 by martis@chromium.org, Nov 29 2017

Labels: OS-Android OS-Chrome OS-iOS OS-Mac
Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40ffa19684348c6e3ede1d06de00e3bf4728ccdf

commit 40ffa19684348c6e3ede1d06de00e3bf4728ccdf
Author: Timothy Loh <timloh@chromium.org>
Date: Thu Nov 30 05:52:03 2017

Revert "Record and reuse most recent target language."

This reverts commit 32365f399cf6f0cd7387480ed95c439ac85ac0b7.

Reason for revert: Added test TranslateLanguageBrowserTest.RecentTargetLanguage is flaky

e.g. see https://chromium-swarm.appspot.com/task?id=3a2181a949be7f10&refresh=10&show_raw=1
Check failed: expect_translate != bubble == nullptr (1 vs. 1)

Original change's description:
> Record and reuse most recent target language.
>
> This change introduces a synced preference that tracks the language
> that the user most-recently chose as a target language. This language
> is then offered as the default target language.
>
> Bug:  624604 
> Change-Id: I8be60e81db2476e83707c090b34a0c6d955bbd25
> Reviewed-on: https://chromium-review.googlesource.com/757882
> Commit-Queue: Michael Martis <martis@chromium.org>
> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Renjie Liu <renjieliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519975}

TBR=hajimehoshi@chromium.org,renjieliu@chromium.org,martis@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  624604 ,  789593 
Change-Id: I8750661898b9cfd7ce888fce9ca43d0b5add699f
Reviewed-on: https://chromium-review.googlesource.com/799011
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520453}
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/translate/translate_bubble_test_utils.h
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/views/translate/translate_bubble_test_utils_views.cc
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/views/translate/translate_language_browsertest.cc
[delete] https://crrev.com/332e801f018a773c9920c0551b4e765b3b422177/chrome/test/data/italian_page.html
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_ui_delegate.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e48850d972279a4ad261f741a21752f0f5ed7f1c

commit e48850d972279a4ad261f741a21752f0f5ed7f1c
Author: Michael Martis <martis@chromium.org>
Date: Thu Nov 30 09:44:41 2017

Fixed flaky test for recent target language.

This patch is exactly the same as
https://chromium-review.googlesource.com/757882 except for new logic in
NavigateToUrl.

Bug:  789593 ,  624604 
Change-Id: I90cb4f640ca4296ae7d4a88bd17808ebe63566e9
Reviewed-on: https://chromium-review.googlesource.com/798816
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520493}
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/translate/translate_bubble_test_utils.h
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/views/translate/translate_bubble_test_utils_views.cc
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/views/translate/translate_language_browsertest.cc
[add] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/test/data/italian_page.html
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_ui_delegate.cc
►

Sign in to add a comment