New issue
Advanced search Search tips

Issue 624602 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 565510



Sign in to add a comment

Rename AbstractAudioContext to BaseAudioContext

Project Member Reported by rtoy@chromium.org, Jun 29 2016

Issue description

The WebAudio spec says there are three context classes:  AudioContext and OfflineAudioContext, which are both derived from BaseAudioContext.

As a first step to separate the mechanical changes with the substantial changes, just rename the existing AbstractAudioContext C++ class to BaseAudioContext.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42bd09051cdcbb26dda15097971ea3843d68943

commit f42bd09051cdcbb26dda15097971ea3843d68943
Author: rtoy <rtoy@chromium.org>
Date: Thu Jul 07 20:29:25 2016

Rename AbstractAudioContext to BaseAudioContext

A mostly mechanical change renaming AbstractAudioContext to
BaseAudioContext to match the class names used in the WebAudio spec.
This is a first step in actually implementing the BaseAudioContext
class as required.

The change is done using

for f in *.cpp *.h
do
  sed -i 's/AbstractAudioContext/BaseAudioContext/g' $f
done

And manually updating AudioContext.idl and renaming
AbstractAudioContext.* to BaseAudioContext.*, and ordering the
include files correctly.

BUG= 624602 
TEST=

Review-Url: https://codereview.chromium.org/2103043007
Cr-Commit-Position: refs/heads/master@{#404234}

[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AnalyserNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioContext.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioContext.idl
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioListener.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/AudioSourceNode.h
[rename] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[rename] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ConvolverNodeTest.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DelayNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/GainNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/OscillatorNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/PannerNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/PeriodicWave.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNodeTest.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.h
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/StereoPannerNodeTest.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
[modify] https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.h

Comment 2 by rtoy@chromium.org, Jul 13 2016

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment