New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 624527 link

Starred by 2 users
Status: Fixed
Owner:
█ chongz@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
brucedaw...@chromium.org
█ chongz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 612736
Blocking:
issue 633136



Sign in to add a comment

Suppress DrMemory failure on LoadKeyboardLayout() for Korean&Japanese layout

Project Member Reported by chongz@chromium.org, Jun 29 2016 
On windows calling LoadKeyboardLayout() with Korean or Japanese layout will fail DrMemory test.

According to https://bugs.chromium.org/p/chromium/issues/detail?id=612736#c11
it seems either to be a DrMemory issue or a bug in Windows, and we should add a DrMemory suppression for this.

Note:
"mock_keyboard.h" has the similar issue, e.g.
Call "MockKeyboard::GetCharacters(MockKeyboard::LAYOUT_KOREAN, ..)" somewhere and DrMemory full test will fail.

Comment 1 by tmonius...@opera.com, Sep 16 2016

Blocking: 633136
Fix for 633136 is going to require DrMemory suppression: https://codereview.chromium.org/2197113002/diff/20001/ui/events/test/keyboard_layout_win.cc#newcode31

Comment 2 by chongz@chromium.org, Jan 10 2017

Status: Fixed (was: Assigned)
The DrMemory failure should've been fixed as https://codereview.chromium.org/2353333002 was landed and working.
►

Sign in to add a comment