New issue
Advanced search Search tips

Issue 624526 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocked on:
issue 668278

Blocking:
issue 605745



Sign in to add a comment

Location icon bubble arrow has glitch at 1.5x

Project Member Reported by scottmg@chromium.org, Jun 29 2016

Issue description

See attached when opening lock on Windows 53.0.2782.0 (Official Build) canary (32-bit).

There's some funny bits between the arrow and the main part of the window.

xref to https://bugs.chromium.org/p/chromium/issues/detail?id=615153 which seems similar.
 
cert_arrow.png
17.1 KB View Download
Cc: -bsep@chromium.org
Labels: M-53 Proj-MaterialDesign-NativeUI OS-Chrome OS-Linux
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Location icon bubble arrow has glitch at 1.5x (was: 1.5x glitch in cert dialog in md topchrome)
It also looks to me like there's an issue with how the arrow is stroked, where the left side isn't stroked correctly.  I saw something like this at 2x scale also.

If that isn't fixed in this bug we should file a followup for it.

Comment 3 by bsep@chromium.org, Jun 29 2016

Yeah I fixed something like that with the previous bug, where ostensibly hairline strokes were losing precision and drawing weirdly. I'll take a look at it too. I opened the cert bubble at 1.25 and I saw a couple places where it's doing that.
I suspect any issues here are common to all bubbles and not location-icon-specific, so fixing this would improve a number of places.

Comment 5 by bsep@chromium.org, Jun 30 2016

Blocking: 605745
Labels: -Proj-MaterialDesign-NativeUI -M-53
This actually happens regardless of whether MD is on or not. I'll still try to fix it now because the other bug is fresh in my mind.

Comment 6 by bsep@chromium.org, Jul 13 2016

The main issue is that bubbles are still painted with images, and those seem to have a lot of issues at fractional dsfs. I hacked the bubble to draw programmatically and I think it looks decent (see attached screenshots). There are two issues before I actually submit this though:

1. It's tricky to get the bubble borders to draw transparent, like they are in the image version. I don't know how much we care about keeping it that way.

2. There are a bunch of variations on the bubbles that as far as I can tell are used almost nowhere. For example there's a "BIG_SHADOW" type which is used by app_list_view and tray_bubble_view, neither of which I can figure out how to trigger. It'd be great to pare these down to what we care about, which if it were up to me would be only "small shadow" and maybe "no shadow."
cert-bubble-no-images.PNG
48.3 KB View Download
cert-bubble-no-images-150%.PNG
80.9 KB View Download
bookmark-bubble-no-images.PNG
14.1 KB View Download
The specific special cases you mention both sound like CrOS-specific UI to me.

Can you say more about what you mean regarding the border transparency?  Maybe a comparison shot along with a description of the issue and e.g. why just drawing with a non-255 alpha value doesn't work.

Comment 8 by bsep@chromium.org, Jul 18 2016

If you think it'd be prudent I can enable my new UI only for Windows, and then specialists for other platforms can do the work to enable it elsewhere. Then I can focus on small/no shadow.

I'll write up more about the border transparency in a bit.
I don't think that would be a good idea.  Such a change would require us to have both programmatic and image-based paths in the codebase.  We should try to address all of views at once.
I think bug 590285 comment 27 problem 1 is probably covered under this bug.  Do you agree?

Comment 11 by bsep@chromium.org, Aug 3 2016

#10: I don't think so actually. I see the same kind of artifact at 1x and 2x, so it doesn't have to do with hidpi.
Hmm.  Does it repro in non-material as well or is it at least MD-specific?

I assume you're on the hook for "draw bubble borders in a non-crappy way" and thus this would still be on your plate even if it's a separate issue, but if you're not going to file a bug for it tell me.

Comment 13 by bsep@chromium.org, Aug 9 2016

#12: I filed  bug 635996  for that.

Comment 14 by bsep@chromium.org, Nov 23 2016

Blocking: 668278

Comment 15 by bsep@chromium.org, Nov 23 2016

Blocking: -668278

Comment 16 by bsep@chromium.org, Nov 23 2016

Blockedon: 668278
Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Status: WontFix (was: Archived)
We no longer draw these arrows.

Sign in to add a comment