"gfx_unittests (with patch)" is flaky |
|||||||
Issue description"gfx_unittests (with patch)" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJQsSBUZsYWtlIhpnZnhfdW5pdHRlc3RzICh3aXRoIHBhdGNoKQw.
,
Jun 30 2016
Detected 4 new flakes for test/step "gfx_unittests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJQsSBUZsYWtlIhpnZnhfdW5pdHRlc3RzICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app.
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccba06ef213539ffc795b525343fd2aec980c286 commit ccba06ef213539ffc795b525343fd2aec980c286 Author: magjed <magjed@chromium.org> Date: Fri Jul 01 14:32:19 2016 Disable tests RenderTextTest.StringSizeBoldWidth/TextDoesntClip on Win NOTRY=true BUG= 624513 TBR=asvitkine Review-Url: https://codereview.chromium.org/2114933003 Cr-Commit-Position: refs/heads/master@{#403451} [modify] https://crrev.com/ccba06ef213539ffc795b525343fd2aec980c286/ui/gfx/render_text_unittest.cc
,
Jul 1 2016
asvitkine - Assigning to you since you are listed as font rendering owner in ui/gfx/OWNERS.
,
Jul 4 2016
Sorry, I don't work in this area anymore. +msw who I think still occasionally works on this code. Maybe a good candidate for the product excellence fixit?
,
Jul 6 2016
This may be due to the new DirectWrite fallback codepath: https://codereview.chromium.org/2054273002
,
Jul 7 2016
Since the flakes started happening before the DirectWrite fallback landed, I don't think that's the cause.
,
Jul 7 2016
Ah, your change did land after the flakes started. Feel free to mark available.
,
Jul 7 2016
From briefly looking at the logs, RenderTextTest.TextDoesntClip is failing because the color is just slightly off-white. I wonder if it's possible that AA is bleeding outside the expected rect?
,
Jul 7 2016
Quite possible. That's probably fine - maybe the fix is to make the test more tolerant to white-like colors? Is it something you can look at fixing?
,
Jul 10 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3af00bdb89c68853a0040d507a048c79396d00d9 commit 3af00bdb89c68853a0040d507a048c79396d00d9 Author: Ben Wagner <bungeman@chromium.org> Date: Wed Oct 25 19:01:52 2017 RenderText to consider style for bounds. This fixes a long standing TODO to account for stylized baselines in string sizing. This appears to be the cause of a number of confusing work-arounds in the RenderTextTest.TextDoesntClip/HarfBuzz test. This test checks that text draws inside the calculated bounds, but these calculated bounds do not take into account the fake super and subscripting RenderText allows. As a result, this test only passed in the past by accident, the fake super and subscripts just happened to barely squeeze into the base font's bounds. BUG= skia:6931 , chromium:459812 , chromium:624513 , chromium:640068 Change-Id: I224a1e9526f04525ac8581819ad60bd9f90ffa0e Reviewed-on: https://chromium-review.googlesource.com/735783 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#511542} [modify] https://crrev.com/3af00bdb89c68853a0040d507a048c79396d00d9/ui/gfx/render_text_harfbuzz.cc [modify] https://crrev.com/3af00bdb89c68853a0040d507a048c79396d00d9/ui/gfx/render_text_unittest.cc
,
Oct 26 2017
The RenderTextTest.TextDoesntClip test has been re-enabled on Windows and hopefully the underlying reason for it to be disabled has been fixed. However, RenderTextTest.StringSizeBoldWidth is still disabled (this test would need to directly control the set of fonts used to be re-enabled, I think). So this seems to be half fixed.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9 commit d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Nov 21 19:31:18 2018 Enable disabled tests in ui/gfx/. These pass on Windows. Bug: 320050 , 327287 , 406574 , 427184 , 624513 , 701241, 865527 Change-Id: I51db36ebd63ca17b60eff0bf999ed3aae9ddd958 Reviewed-on: https://chromium-review.googlesource.com/c/1338955 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610157} [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/color_transform_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/font_names_testing.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/font_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/text_utils_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/transform_unittest.cc
,
Nov 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by magjed@chromium.org
, Jun 30 2016