New issue
Advanced search Search tips

Issue 624509 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 624136

Blocking:
issue 581462



Sign in to add a comment

Delete unecessary StructTraits

Project Member Reported by rjkroege@chromium.org, Jun 29 2016

Issue description

Remove the mojo array to std::vector StructTraits code that exists only to work around the existence of  http://crbug.com/624136 

 
Blocking: 581462
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76d6d9c5e3be62df7beb5f047e26b292997904de

commit 76d6d9c5e3be62df7beb5f047e26b292997904de
Author: erg <erg@chromium.org>
Date: Tue May 02 18:54:51 2017

Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG= 624509 

Review-Url: https://codereview.chromium.org/2850733003
Cr-Commit-Position: refs/heads/master@{#468725}

[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/services/ui/public/interfaces/cursor/BUILD.gn
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/services/ui/public/interfaces/cursor/cursor_struct_traits.cc
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/services/ui/public/interfaces/cursor/cursor_struct_traits_unittest.cc
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/skia/public/interfaces/BUILD.gn
[delete] https://crrev.com/8b24c49c7e35918e4aa21ba770e0e0bc54c8dd0c/skia/public/interfaces/bitmap_array.mojom
[delete] https://crrev.com/8b24c49c7e35918e4aa21ba770e0e0bc54c8dd0c/skia/public/interfaces/bitmap_array.typemap
[delete] https://crrev.com/8b24c49c7e35918e4aa21ba770e0e0bc54c8dd0c/skia/public/interfaces/bitmap_array_struct_traits.h
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/skia/public/interfaces/test/struct_traits_unittest.cc
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/skia/public/interfaces/test/traits_test_service.mojom
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/skia/public/interfaces/typemaps.gni
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/ui/ozone/public/interfaces/BUILD.gn
[modify] https://crrev.com/76d6d9c5e3be62df7beb5f047e26b292997904de/ui/ozone/public/interfaces/device_cursor.mojom

Status: Fixed (was: Assigned)

Sign in to add a comment