New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624494 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 635951



Sign in to add a comment

Introduce a new target type for targets that only have Javascript

Project Member Reported by eostroukhov@chromium.org, Jun 29 2016

Issue description

A new target type is needed for the targets that do not support any features other then core JavaScript
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d4a941b4801e7cb2828600675751c35750b330

commit 33d4a941b4801e7cb2828600675751c35750b330
Author: eostroukhov <eostroukhov@google.com>
Date: Thu Jul 07 02:35:50 2016

[DevTools] No NetworkManager and NetworkLog for v8only mode

R=alph@chromium.org, dgozman@chromium.org
BUG= 624494 

Review-Url: https://codereview.chromium.org/2109813003
Cr-Commit-Position: refs/heads/master@{#404032}

[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
[modify] https://crrev.com/33d4a941b4801e7cb2828600675751c35750b330/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1781e8c7f28068c35869e760e8adc0db04d69453

commit 1781e8c7f28068c35869e760e8adc0db04d69453
Author: eostroukhov <eostroukhov@google.com>
Date: Wed Jul 13 23:11:46 2016

[DevTools] Replace the target type with capabilities

Capabilities allow for more flexible specification of the devtools
features available when working with a specific target.

BUG= 624494 

Review-Url: https://codereview.chromium.org/2137773002
Cr-Commit-Position: refs/heads/master@{#405344}

[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastApp.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/1781e8c7f28068c35869e760e8adc0db04d69453/third_party/WebKit/Source/devtools/front_end/timeline_model/LayerTreeModel.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/becc4e65e5d4497a460323ccf9afbfde3a816dee

commit becc4e65e5d4497a460323ccf9afbfde3a816dee
Author: eostroukhov <eostroukhov@google.com>
Date: Thu Jul 14 22:17:33 2016

[DevTools] Support for the inspector target type

No longer try to set overlay message and no longer send
"Inspecotr.enable" message to the targets of JS inspector type.

BUG= 624494 

Review-Url: https://codereview.chromium.org/2122113004
Cr-Commit-Position: refs/heads/master@{#405601}

[modify] https://crrev.com/becc4e65e5d4497a460323ccf9afbfde3a816dee/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/becc4e65e5d4497a460323ccf9afbfde3a816dee/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41

commit cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41
Author: eostroukhov <eostroukhov@google.com>
Date: Tue Jul 26 01:41:28 2016

[DevTools] No longer store security origins in RTM

This refactoring decouples storage models from the ResourceTreeModel.

BUG= 624494 
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2172753002
Cr-Commit-Position: refs/heads/master@{#407678}

[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-data-expected.txt
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-data.html
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-names-expected.txt
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-names.html
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-structure.html
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/resources-panel-expected.txt
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/upgrade-events-expected.txt
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/upgrade-events.html
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-events.html
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/devtools.gypi
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[add] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
[modify] https://crrev.com/cf6a5a7cab6d500e2e6ec5be92bbd6befbeffd41/third_party/WebKit/Source/devtools/front_end/sdk/module.json

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a9636b7c53deeb242c48968de9134f8603f378

commit 98a9636b7c53deeb242c48968de9134f8603f378
Author: eostroukhov <eostroukhov@google.com>
Date: Wed Jul 27 23:13:13 2016

[DevTools] Track URL through the target

BUG= 624494 
R=dgozman

Review-Url: https://codereview.chromium.org/2186753002
Cr-Commit-Position: refs/heads/master@{#408267}

[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-image.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/components/linkifier.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-breakpoints-not-activated-on-reload.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-disable-add-breakpoint.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/pause-in-inline-script.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/selected-call-frame-after-formatting-source.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-disable-enable.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scripts.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-live-edit.html
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
[modify] https://crrev.com/98a9636b7c53deeb242c48968de9134f8603f378/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js

Blocking: 635951
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dd9c79c7dbb77d370e6f17ee504320a76aaac24

commit 9dd9c79c7dbb77d370e6f17ee504320a76aaac24
Author: eostroukhov <eostroukhov@google.com>
Date: Thu Aug 18 18:25:42 2016

[DevTools] Explicitly require ResourceTreeModel

BUG= 624494 

Review-Url: https://codereview.chromium.org/2168323002
Cr-Commit-Position: refs/heads/master@{#412894}

[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
[modify] https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e34d0a4a39bc5c48d94b4eaa362d64908e891794

commit e34d0a4a39bc5c48d94b4eaa362d64908e891794
Author: allada <allada@chromium.org>
Date: Mon Aug 22 23:41:49 2016

[Devtools] [Regression fix] Network Requests with data urls

Fixed Regression caused from https://codereview.chromium.org/2186753002
which caused network requests from data url parents to cause devtools
to throw an exception because there is no host of the parent frame.

R=lushnikov
BUG= 639469 ,  624494 

Review-Url: https://codereview.chromium.org/2266473003
Cr-Commit-Position: refs/heads/master@{#413585}

[modify] https://crrev.com/e34d0a4a39bc5c48d94b4eaa362d64908e891794/third_party/WebKit/LayoutTests/http/tests/inspector/network/request-name-path-expected.txt
[modify] https://crrev.com/e34d0a4a39bc5c48d94b4eaa362d64908e891794/third_party/WebKit/LayoutTests/http/tests/inspector/network/request-name-path.html
[modify] https://crrev.com/e34d0a4a39bc5c48d94b4eaa362d64908e891794/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d42dc2ec4da4f99302753c0d15b453adf06a64

commit 27d42dc2ec4da4f99302753c0d15b453adf06a64
Author: eostroukhov <eostroukhov@google.com>
Date: Tue Aug 23 02:40:17 2016

[DevTools] Make resource tree model optional

Some targets may not support resource tree, in this case relevant object should not be created.

BUG= 624494 

Review-Url: https://codereview.chromium.org/2122353002
Cr-Commit-Position: refs/heads/master@{#413644}

[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/execution-context-sorted.html
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastApp.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/27d42dc2ec4da4f99302753c0d15b453adf06a64/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Status: Fixed (was: Started)
I no longer see any errors when inspecting Node.js instance.

Sign in to add a comment