New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624470 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

ts_mon: make /chrome/infra prefix configurable

Project Member Reported by sergeybe...@chromium.org, Jun 29 2016

Issue description

This is for both Python and Go versions.

Context: request by tanin@ so ts_mon can be used by other teams.
 
Labels: Pri-2
Setting initial priority

Comment 2 by ta...@google.com, Jul 1 2016

Status: Assigned (was: Untriaged)
Owner: tanin@chromium.org
I suppose you meant to assign yourself as an owner (status Assigned without an owner doesn't make sense :-)

Comment 4 by ta...@google.com, Jul 1 2016

I thought I did put myself as the owner... noogler's mistake :s

Comment 5 by ta...@google.com, Jul 1 2016

For this, I think we are going to add --ts-mon-metrics-name-prefix as a command-line argument.

I'm worried about defaulting its value to '/chrome/infra'. Because users might accidentally push metrics to /chrome/infra.

We should require this argument. But that will break the current user (which is chrome-infra team).

any thought?
I'd say, let's do one change at a time. 

1. Add the new argument and default it to '/chrome/infra/' - this will be backwards compatible with all of our current usage. This step alone should be the scope of this bug.

2. Upgrade all tools and services to require the new argument, or have it supplied through the config file. This step will take a while, and may need to involve many people's projects.

3. Make the new flag required. This is a breaking change, and will require an announcement and close monitoring + possibly last minute fixes.

In the meantime, we should also start checking for the correct prefix at our proxy, to make sure the parameter is used correctly.

Comment 7 by ta...@google.com, Jul 1 2016

> 1. Add the new argument and default it to '/chrome/infra/' - this will be backwards compatible with all of our current usage. This step alone should be the scope of this bug.

I agree. I will go ahead and add it.
Status: Fixed (was: Assigned)
The fix landed 2 weeks ago (thanks!)

Closing the bug.

Sign in to add a comment