New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 624451 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 597756



Sign in to add a comment

[Blimp Client] Settings UI

Project Member Reported by dtrainor@chromium.org, Jun 29 2016

Issue description

Build the v0.6 settings UI.  This involves the following tasks:

- Building out a Blimp settings page much like the v0.5 client (for now).
- Tying the Blimp settings page to a new settings item in Clank's Advanced mode (only if building for the Blimp target).  This might be a bit tricky because we don't want this menu item included for the Clank APK.
 
If Blimp is turned on/off, we should probably also close all open tabs and restart the application (for now).
Do I need to port the network connection code to blimp server in this CL? 

Since we can read engine ip from the UI. But porting network connection code seems to be a lot of work.
Blocking: 597756
Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27752d3ef4b6b938bcc3533797348fca37346151

commit 27752d3ef4b6b938bcc3533797348fca37346151
Author: xingliu <xingliu@chromium.org>
Date: Wed Jul 27 23:58:23 2016

Blimp settings UI integration for Chrome, everything still lives in Blimp.

Previously Blimp code is in blimp/app, this CL port settings UI code to core, and reuse Java resources files in blimp/app.(We can setup new one in core or somewhere if needed)

In this way, all UI resources, and code live in Blimp so we don't leak things to Chrome at the moment.

For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG= 624451 

Review-Url: https://codereview.chromium.org/2173563003
Cr-Commit-Position: refs/heads/master@{#408281}

[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/BUILD.gn
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/AndroidManifest.xml.jinja2
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/java/res/values/arrays.xml
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/java/res/xml/about_blimp_preferences.xml
[add] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/java/res/xml/blimp_preferences.xml
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/java/src/org/chromium/blimp/preferences/PreferencesUtil.java
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/java/strings/android_blimp_strings.grd
[add] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java
[add] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/MockPreferences.java
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/core/BUILD.gn
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java
[add] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
[add] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/public/BUILD.gn
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
[add] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpSettingsCallbacks.java
[add] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/chrome/android/java/src/org/chromium/chrome/browser/blimp/BlimpSettingsCallbacksImpl.java
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[modify] https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151/chrome/android/java_sources.gni

Status: Fixed (was: Assigned)
Cl has been merged, there will be other CL hooks the ui with authentication flow. 
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5f7fda40e4827bd9d9114acef9b126893b59892

commit d5f7fda40e4827bd9d9114acef9b126893b59892
Author: xingliu <xingliu@chromium.org>
Date: Wed Sep 14 22:52:55 2016

Propagate connection info to Blimp android UI.

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG= 624451 , 646655

Review-Url: https://codereview.chromium.org/2322843002
Cr-Commit-Position: refs/heads/master@{#418707}

[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/app/android/java/res/xml/blimp_preferences.xml
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/session/BUILD.gn
[add] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/session/connection_status.cc
[add] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/session/connection_status.h
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/settings/BUILD.gn
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/settings/android/blimp_settings_android.cc
[modify] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/settings/android/blimp_settings_android.h
[add] https://crrev.com/d5f7fda40e4827bd9d9114acef9b126893b59892/blimp/client/core/settings/blimp_settings_delegate.h

Labels: Archive-Blimp

Sign in to add a comment